mirror of
https://github.com/hardkernel/linux.git
synced 2026-06-05 02:21:52 +09:00
octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_flows.c
[ Upstream commit bd3110bc102ab6292656b8118be819faa0de8dd0 ] Adding error pointer check after calling otx2_mbox_get_rsp(). Fixes:9917060fc3("octeontx2-pf: Cleanup flow rule management") Fixes:f0a1913f8a("octeontx2-pf: Add support for ethtool ntuple filters") Fixes:674b3e1642("octeontx2-pf: Add additional checks while configuring ucast/bcast/mcast rules") Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com> Reviewed-by: Simon Horman <horms@kernel.org> Signed-off-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
05a6ce174c
commit
8c9f8b35dc
@@ -121,6 +121,8 @@ int otx2_alloc_mcam_entries(struct otx2_nic *pfvf, u16 count)
|
||||
|
||||
rsp = (struct npc_mcam_alloc_entry_rsp *)otx2_mbox_get_rsp
|
||||
(&pfvf->mbox.mbox, 0, &req->hdr);
|
||||
if (IS_ERR(rsp))
|
||||
goto exit;
|
||||
|
||||
for (ent = 0; ent < rsp->count; ent++)
|
||||
flow_cfg->flow_ent[ent + allocated] = rsp->entry_list[ent];
|
||||
@@ -199,6 +201,10 @@ static int otx2_mcam_entry_init(struct otx2_nic *pfvf)
|
||||
|
||||
rsp = (struct npc_mcam_alloc_entry_rsp *)otx2_mbox_get_rsp
|
||||
(&pfvf->mbox.mbox, 0, &req->hdr);
|
||||
if (IS_ERR(rsp)) {
|
||||
mutex_unlock(&pfvf->mbox.lock);
|
||||
return PTR_ERR(rsp);
|
||||
}
|
||||
|
||||
if (rsp->count != req->count) {
|
||||
netdev_info(pfvf->netdev,
|
||||
@@ -234,6 +240,10 @@ static int otx2_mcam_entry_init(struct otx2_nic *pfvf)
|
||||
|
||||
frsp = (struct npc_get_field_status_rsp *)otx2_mbox_get_rsp
|
||||
(&pfvf->mbox.mbox, 0, &freq->hdr);
|
||||
if (IS_ERR(frsp)) {
|
||||
mutex_unlock(&pfvf->mbox.lock);
|
||||
return PTR_ERR(frsp);
|
||||
}
|
||||
|
||||
if (frsp->enable) {
|
||||
pfvf->flags |= OTX2_FLAG_RX_VLAN_SUPPORT;
|
||||
|
||||
Reference in New Issue
Block a user