ANDROID: mm: page_pinner: remove dump_page_pinner

This patch removes dump_page_pinner since it was not useful(IOW,
the page_pinner buffer to keep the history is enough).

This patch also changes mismatched printf format specifier.

Bug: 218731671
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Minchan Kim <minchan@google.com>
Change-Id: I80c6f5ad656b3b0d27a50eabff4d1382559aa105
This commit is contained in:
Minchan Kim
2022-04-07 09:09:00 -07:00
parent 94c6c10c39
commit 8fe46774c6
3 changed files with 1 additions and 60 deletions

View File

@@ -10,7 +10,6 @@ extern struct static_key_true failure_tracking;
extern struct page_ext_operations page_pinner_ops;
extern void __free_page_pinner(struct page *page, unsigned int order);
extern void __dump_page_pinner(struct page *page);
void __page_pinner_failure_detect(struct page *page);
void __page_pinner_put_page(struct page *page);
@@ -20,12 +19,6 @@ static inline void free_page_pinner(struct page *page, unsigned int order)
__free_page_pinner(page, order);
}
static inline void dump_page_pinner(struct page *page)
{
if (static_branch_unlikely(&page_pinner_inited))
__dump_page_pinner(page);
}
static inline void page_pinner_put_page(struct page *page)
{
if (!static_branch_unlikely(&failure_tracking))
@@ -45,9 +38,6 @@ static inline void page_pinner_failure_detect(struct page *page)
static inline void free_page_pinner(struct page *page, unsigned int order)
{
}
static inline void dump_page_pinner(struct page *page)
{
}
static inline void page_pinner_put_page(struct page *page)
{
}

View File

@@ -192,7 +192,6 @@ void dump_page(struct page *page, const char *reason)
{
__dump_page(page, reason);
dump_page_owner(page);
dump_page_pinner(page);
}
EXPORT_SYMBOL(dump_page);

View File

@@ -194,7 +194,7 @@ print_page_pinner(char __user *buf, size_t count, struct captured_pinner *record
return -ENOMEM;
if (record->state == PP_PUT) {
ret = snprintf(kbuf, count, "At least, pinned for %lld us\n",
ret = snprintf(kbuf, count, "At least, pinned for %llu us\n",
record->elapsed);
} else {
u64 ts_usec = record->ts_usec;
@@ -243,54 +243,6 @@ err:
return -ENOMEM;
}
void __dump_page_pinner(struct page *page)
{
struct page_ext *page_ext = lookup_page_ext(page);
struct page_pinner *page_pinner;
depot_stack_handle_t handle;
unsigned long *entries;
unsigned int nr_entries;
int pageblock_mt;
unsigned long pfn;
int count;
unsigned long rem_usec;
u64 ts_usec;
if (unlikely(!page_ext)) {
pr_alert("There is not page extension available.\n");
return;
}
page_pinner = get_page_pinner(page_ext);
count = atomic_read(&page_pinner->count);
if (!count) {
pr_alert("page_pinner info is not present (never set?)\n");
return;
}
pfn = page_to_pfn(page);
ts_usec = page_pinner->ts_usec;
rem_usec = do_div(ts_usec, 1000000);
pr_alert("page last pinned %5lu.%06lu] count %d\n",
ts_usec, rem_usec, count);
pageblock_mt = get_pageblock_migratetype(page);
pr_alert("PFN %lu Block %lu type %s Flags %#lx(%pGp)\n",
pfn,
pfn >> pageblock_order,
migratetype_names[pageblock_mt],
page->flags, &page->flags);
handle = READ_ONCE(page_pinner->handle);
if (!handle) {
pr_alert("page_pinner allocation stack trace missing\n");
} else {
nr_entries = stack_depot_fetch(handle, &entries);
stack_trace_print(entries, nr_entries, 0);
}
}
void __page_pinner_failure_detect(struct page *page)
{
struct page_ext *page_ext = lookup_page_ext(page);