shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-09 12:17:12 +09:00
Code Issues Packages Projects Releases Wiki Activity

f2fs: fix iostat lock protection

Browse Source 
commit 144f1cd40b upstream.

Made iostat lock irq safe to avoid potentinal deadlock.

Deadlock scenario:
f2fs_attr_store
  -> f2fs_sbi_store
  -> _sbi_store
  -> spin_lock(sbi->iostat_lock)
    <interrupt request>
    -> scsi_end_request
    -> bio_endio
    -> f2fs_dio_read_end_io
    -> f2fs_update_iostat
    -> spin_lock_irqsave(sbi->iostat_lock)  ===> Dead lock here

Fixes: 61803e9843 ("f2fs: fix iostat related lock protection")
Fixes: a1e09b03e6 ("f2fs: use iomap for direct I/O")
Signed-off-by: Qilin Tan <qilin.tan@mediatek.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Daniel Rosenberg <drosen@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Qilin Tan
2023-03-31 17:26:56 +08:00
committed by Greg Kroah-Hartman
parent d3b74c288d
commit 9214a5484e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
fs/f2fs/sysfs.c
View File

@@ -403,9 +403,9 @@ out:
if (!strcmp(a->attr.name, "iostat_period_ms")) { if (!strcmp(a->attr.name, "iostat_period_ms")) {
if (t < MIN_IOSTAT_PERIOD_MS || t > MAX_IOSTAT_PERIOD_MS) if (t < MIN_IOSTAT_PERIOD_MS || t > MAX_IOSTAT_PERIOD_MS)
return -EINVAL; return -EINVAL;
spin_lock(&sbi->iostat_lock); spin_lock_irq(&sbi->iostat_lock);
sbi->iostat_period_ms = (unsigned int)t; sbi->iostat_period_ms = (unsigned int)t;
spin_unlock(&sbi->iostat_lock); spin_unlock_irq(&sbi->iostat_lock);
return count; return count;
} }