From 943e50cc0641ba792f6a3ace60d7b4f9ac0602d2 Mon Sep 17 00:00:00 2001 From: Xingyu Chen Date: Thu, 12 Sep 2019 11:04:08 +0800 Subject: [PATCH] iio: adc: coverity defect cleanup [1/1] PD#SWPL-13967 Problem: unchecked return value of regmap_write Solution: to check the return value Verify: test pass on g12a Change-Id: Ibb45e36d7c24f0e0ea8b14da75e887321ee5b791 Signed-off-by: Xingyu Chen --- drivers/amlogic/iio/adc/meson_saradc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/amlogic/iio/adc/meson_saradc.c b/drivers/amlogic/iio/adc/meson_saradc.c index 581f1d07af1a..c34cb78099e7 100644 --- a/drivers/amlogic/iio/adc/meson_saradc.c +++ b/drivers/amlogic/iio/adc/meson_saradc.c @@ -962,7 +962,9 @@ static int meson_sar_adc_init(struct iio_dev *indio_dev) regval |= i << MESON_SAR_ADC_AUX_SW_MUX_SEL_CHAN_SHIFT(i); regval |= MESON_SAR_ADC_AUX_SW_YP_DRIVE_SW; regval |= MESON_SAR_ADC_AUX_SW_XP_DRIVE_SW; - regmap_write(priv->regmap, MESON_SAR_ADC_AUX_SW, regval); + ret = regmap_write(priv->regmap, MESON_SAR_ADC_AUX_SW, regval); + if (ret) + return ret; /* must be set to <1> for g12a and later SoCs */ regmap_update_bits(priv->regmap, MESON_SAR_ADC_REG11,