shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-05 10:31:46 +09:00
Code Issues Packages Projects Releases Wiki Activity

x86/ibt: Keep IBT disabled during alternative patching

Browse Source 
commit ebebe30794d38c51f71fe4951ba6af4159d9837d upstream.

cfi_rewrite_callers() updates the fineIBT hash matching at the caller side,
but except for paranoid-mode it relies on apply_retpoline() and friends for
any ENDBR relocation. This could temporarily cause an indirect branch to
land on a poisoned ENDBR.

For instance, with para-virtualization enabled, a simple wrmsrl() could
have an indirect branch pointing to native_write_msr() who's ENDBR has been
relocated due to fineIBT:

<wrmsrl>:
       push   %rbp
       mov    %rsp,%rbp
       mov    %esi,%eax
       mov    %rsi,%rdx
       shr    $0x20,%rdx
       mov    %edi,%edi
       mov    %rax,%rsi
       call   *0x21e65d0(%rip)        # <pv_ops+0xb8>
       ^^^^^^^^^^^^^^^^^^^^^^^

Such an indirect call during the alternative patching could #CP if the
caller is not *yet* adjusted for the new target ENDBR. To prevent a false
 #CP, keep CET-IBT disabled until all callers are patched.

Patching during the module load does not need to be guarded by IBT-disable
because the module code is not executed until the patching is complete.

  [ pawan: Since apply_paravirt() happens before __apply_fineibt()
	   relocates the ENDBR, pv_ops in the example above is not relevant.
	   It is still safer to keep this commit because missing an ENDBR
	   means an oops. ]

Signed-off-by: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: Alexandre Chartre <alexandre.chartre@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Pawan Gupta
2025-05-03 09:46:31 -07:00
committed by Greg Kroah-Hartman
parent e6da4a83e3
commit 9502e83c22
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
arch/x86/kernel/alternative.c
View File

@@ -30,6 +30,7 @@
#include <asm/fixmap.h> #include <asm/fixmap.h>
#include <asm/paravirt.h> #include <asm/paravirt.h>
#include <asm/asm-prototypes.h> #include <asm/asm-prototypes.h>
#include <asm/cfi.h>
int __read_mostly alternatives_patched; int __read_mostly alternatives_patched;
@@ -1006,6 +1007,8 @@ static noinline void __init int3_selftest(void)
void __init alternative_instructions(void) void __init alternative_instructions(void)
{ {
u64 ibt;
int3_selftest(); int3_selftest();
/* /*
@@ -1043,6 +1046,9 @@ void __init alternative_instructions(void)
*/ */
paravirt_set_cap(); paravirt_set_cap();
/* Keep CET-IBT disabled until caller/callee are patched */
ibt = ibt_save();
/* /*
* First patch paravirt functions, such that we overwrite the indirect * First patch paravirt functions, such that we overwrite the indirect
* call with the direct call. * call with the direct call.
@@ -1064,6 +1070,8 @@ void __init alternative_instructions(void)
apply_ibt_endbr(__ibt_endbr_seal, __ibt_endbr_seal_end); apply_ibt_endbr(__ibt_endbr_seal, __ibt_endbr_seal_end);
ibt_restore(ibt);
#ifdef CONFIG_SMP #ifdef CONFIG_SMP
/* Patch to UP if other cpus not imminent. */ /* Patch to UP if other cpus not imminent. */
if (!noreplace_smp && (num_present_cpus() == 1 || setup_max_cpus <= 1)) { if (!noreplace_smp && (num_present_cpus() == 1 || setup_max_cpus <= 1)) {