shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-07 19:30:30 +09:00
Code Issues Packages Projects Releases Wiki Activity

firmware: cirrus: cs_dsp: Initialize debugfs_root to invalid

Browse Source 
[ Upstream commit 66626b15636b5f5cf3d7f6104799f77462748974 ]

Initialize debugfs_root to -ENODEV so that if the client never sets a
valid debugfs root the debugfs files will not be created.

A NULL pointer passed to any of the debugfs_create_*() functions means
"create in the root of debugfs". It doesn't mean "ignore".

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://msgid.link/r/20240307105353.40067-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Richard Fitzgerald
2024-03-07 10:53:53 +00:00
committed by Greg Kroah-Hartman
parent 74ee5e6352
commit 97e16428c2
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/firmware/cirrus/cs_dsp.c
View File

@@ -490,7 +490,7 @@ void cs_dsp_cleanup_debugfs(struct cs_dsp *dsp)
{ {
cs_dsp_debugfs_clear(dsp); cs_dsp_debugfs_clear(dsp);
debugfs_remove_recursive(dsp->debugfs_root); debugfs_remove_recursive(dsp->debugfs_root);
dsp->debugfs_root = NULL; dsp->debugfs_root = ERR_PTR(-ENODEV);
} }
EXPORT_SYMBOL_GPL(cs_dsp_cleanup_debugfs); EXPORT_SYMBOL_GPL(cs_dsp_cleanup_debugfs);
#else #else
@@ -2300,6 +2300,11 @@ static int cs_dsp_common_init(struct cs_dsp *dsp)
mutex_init(&dsp->pwr_lock); mutex_init(&dsp->pwr_lock);
#ifdef CONFIG_DEBUG_FS
/* Ensure this is invalid if client never provides a debugfs root */
dsp->debugfs_root = ERR_PTR(-ENODEV);
#endif
return 0; return 0;
} }