shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-08 20:07:46 +09:00
Code Issues Packages Projects Releases Wiki Activity

inet: add READ_ONCE(sk->sk_bound_dev_if) in inet_csk_bind_conflict()

Browse Source 
[ Upstream commit d2c135619c ]

inet_csk_bind_conflict() can access sk->sk_bound_dev_if for
unlocked sockets.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Eric Dumazet
2022-05-13 11:55:46 -07:00
committed by Greg Kroah-Hartman
parent 49aa080951
commit 9920e87a84
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
net/ipv4/inet_connection_sock.c
View File

@@ -147,10 +147,14 @@ static int inet_csk_bind_conflict(const struct sock *sk,
*/ */
sk_for_each_bound(sk2, &tb->owners) { sk_for_each_bound(sk2, &tb->owners) {
if (sk != sk2 && int bound_dev_if2;
(!sk->sk_bound_dev_if ||
!sk2->sk_bound_dev_if || if (sk == sk2)
sk->sk_bound_dev_if == sk2->sk_bound_dev_if)) { continue;
bound_dev_if2 = READ_ONCE(sk2->sk_bound_dev_if);
if ((!sk->sk_bound_dev_if ||
!bound_dev_if2 ||
sk->sk_bound_dev_if == bound_dev_if2)) {
if (reuse && sk2->sk_reuse && if (reuse && sk2->sk_reuse &&
sk2->sk_state != TCP_LISTEN) { sk2->sk_state != TCP_LISTEN) {
if ((!relax || if ((!relax ||