mirror of
https://github.com/hardkernel/linux.git
synced 2026-06-05 10:31:46 +09:00
pinctrl: qcom: spmi: fix debugfs drive strength
commit 6bc0ebfb1d920f13c522545f114cdabb49e9408a upstream. Commit723e8462a4("pinctrl: qcom: spmi-gpio: Fix the GPIO strength mapping") fixed a long-standing issue in the Qualcomm SPMI PMIC gpio driver which had the 'low' and 'high' drive strength settings switched but failed to update the debugfs interface which still gets this wrong. Fix the debugfs code so that the exported values match the hardware settings. Note that this probably means that most devicetrees that try to describe the firmware settings got this wrong if the settings were derived from debugfs. Before the above mentioned commit the settings would have actually matched the firmware settings even if they were described incorrectly, but now they are inverted. Fixes:723e8462a4("pinctrl: qcom: spmi-gpio: Fix the GPIO strength mapping") Fixes:eadff30244("pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver") Cc: Anjelique Melendez <quic_amelende@quicinc.com> Cc: stable@vger.kernel.org # 3.19 Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Link: https://lore.kernel.org/20241025121622.1496-1-johan+linaro@kernel.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
be063ffa28
commit
9a27ca3da0
@@ -665,7 +665,7 @@ static void pmic_gpio_config_dbg_show(struct pinctrl_dev *pctldev,
|
||||
"push-pull", "open-drain", "open-source"
|
||||
};
|
||||
static const char *const strengths[] = {
|
||||
"no", "high", "medium", "low"
|
||||
"no", "low", "medium", "high"
|
||||
};
|
||||
|
||||
pad = pctldev->desc->pins[pin].drv_data;
|
||||
|
||||
Reference in New Issue
Block a user