shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-05 18:41:58 +09:00
Code Issues Packages Projects Releases Wiki Activity

net: mvpp2: Don't re-use loop iterator

Browse Source 
[ Upstream commit 0aa3ca956c46d849775eae1816cef8fe4bc8b50e ]

This function has a nested loop.  The problem is that both the inside
and outside loop use the same variable as an iterator.  I found this
via static analysis so I'm not sure the impact.  It could be that it
loops forever or, more likely, the loop exits early.

Fixes: 3a616b92a9 ("net: mvpp2: Add TX flow control support for jumbo frames")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/eaa8f403-7779-4d81-973d-a9ecddc0bf6f@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dan Carpenter
2024-07-24 11:06:56 -05:00
committed by Greg Kroah-Hartman
parent c786c37354
commit 9bd159d3e5
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
View File

@@ -953,13 +953,13 @@ static void mvpp2_bm_pool_update_fc(struct mvpp2_port *port,
static void mvpp2_bm_pool_update_priv_fc(struct mvpp2 *priv, bool en) static void mvpp2_bm_pool_update_priv_fc(struct mvpp2 *priv, bool en)
{ {
struct mvpp2_port *port; struct mvpp2_port *port;
int i; int i, j;
for (i = 0; i < priv->port_count; i++) { for (i = 0; i < priv->port_count; i++) {
port = priv->port_list[i]; port = priv->port_list[i];
if (port->priv->percpu_pools) { if (port->priv->percpu_pools) {
for (i = 0; i < port->nrxqs; i++) for (j = 0; j < port->nrxqs; j++)
mvpp2_bm_pool_update_fc(port, &port->priv->bm_pools[i], mvpp2_bm_pool_update_fc(port, &port->priv->bm_pools[j],
port->tx_fc & en); port->tx_fc & en);
} else { } else {
mvpp2_bm_pool_update_fc(port, port->pool_long, port->tx_fc & en); mvpp2_bm_pool_update_fc(port, port->pool_long, port->tx_fc & en);