From 9ed55674339bbe7c95201f12d9aecc0c1469503e Mon Sep 17 00:00:00 2001 From: Yingyuan Zhu Date: Wed, 29 Aug 2018 13:48:27 +0800 Subject: [PATCH] meson: i2c: fix coverity warning PD#172722: meson: i2c: fix coverity warning Here,the value of "ret" must be equal to 0, so that the program cannot execute to the left of the expression "return ret ?: size;". This causes "Logically dead code". Change-Id: Ief0cdb891e5583f0fba1ff166b40a5e71b67342f Signed-off-by: Yingyuan Zhu --- drivers/amlogic/i2c/i2c-meson-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/amlogic/i2c/i2c-meson-master.c b/drivers/amlogic/i2c/i2c-meson-master.c index 85a6b3d2c8be..26c4d6e0bf80 100644 --- a/drivers/amlogic/i2c/i2c-meson-master.c +++ b/drivers/amlogic/i2c/i2c-meson-master.c @@ -525,7 +525,7 @@ static ssize_t meson_i2c_speed_store(struct device *child, return ret; i2c->frequency = val; - return ret ? : size; + return size; } static DEVICE_ATTR(speed, 0644, meson_i2c_speed_show,