From a613fe0d2b76cda212aca9930a9f01d339366a3c Mon Sep 17 00:00:00 2001 From: Jiamin Ma Date: Thu, 31 Aug 2017 09:51:01 +0800 Subject: [PATCH] unifykey: check return value of of_property_read_u32 PD#150092: Calling "of_property_read_u32" without checking return value driver defect clean up: #30 Change-Id: I590627fec489e2251c689b9a013d5c792ff19975 Signed-off-by: Jiamin Ma --- drivers/amlogic/unifykey/unifykey_dts.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/amlogic/unifykey/unifykey_dts.c b/drivers/amlogic/unifykey/unifykey_dts.c index 86e49b925819..2fb59c5d359b 100644 --- a/drivers/amlogic/unifykey/unifykey_dts.c +++ b/drivers/amlogic/unifykey/unifykey_dts.c @@ -287,10 +287,13 @@ int unifykey_dt_create(struct platform_device *pdev) __LINE__); return ret; } - /* set default efuse version info */ - unify_key_info.efuse_version = -1; - of_property_read_u32(pdev->dev.of_node, "efuse-version", + + ret = of_property_read_u32(pdev->dev.of_node, "efuse-version", &unify_key_info.efuse_version); + if (ret != 0) { + pr_info("no efuse-version set, use default value: -1\n"); + unify_key_info.efuse_version = -1; + } pr_info("key unify config unifykey-num is %d\n", key_num); unify_key_info.key_num = key_num;