From af693b73221abc40840c541c8f5e346bee68e5de Mon Sep 17 00:00:00 2001 From: Ye Zhang Date: Mon, 10 Mar 2025 18:17:45 +0800 Subject: [PATCH] gpio: rockchip: release clk correctly when error Fixes: 7b561549e482 ("gpio: rockchip: binding thread to specified cpu") Signed-off-by: Ye Zhang Change-Id: I6e1828400c1d11c8fafdb33561c5673e6efcf934 --- drivers/gpio/gpio-rockchip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index be27f2949081..45605bd019f2 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -1140,7 +1140,7 @@ static int rockchip_gpio_probe(struct platform_device *pdev) ret = rockchip_gpio_parse_irqs(pdev, bank); if (ret < 0) - return ret; + goto err_clk; rockchip_gpio_init_cpuhp(); /* @@ -1213,6 +1213,7 @@ err_unlock: rockchip_gpio_remove_cpuhp(); mutex_unlock(&bank->deferred_lock); +err_clk: clk_disable_unprepare(bank->clk); clk_disable_unprepare(bank->db_clk);