From af88eb49beef6ec8a0de142ec2beb942afec0e09 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Sat, 22 Apr 2023 08:56:49 +0000 Subject: [PATCH] Revert "pwm: meson: Explicitly set .polarity in .get_state()" This reverts commit 6f62d2d396f166a6ea00aec9e00e2a2e76b76249. It breaks the current Android kernel abi. It will be brought back at the next KABI break update. Bug: 161946584 Change-Id: I13e1e6e04d130a364e3c7294daceb50c8ed31957 Signed-off-by: Greg Kroah-Hartman --- drivers/pwm/pwm-meson.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c index 5cd7b90872c6..16d79ca5d8f5 100644 --- a/drivers/pwm/pwm-meson.c +++ b/drivers/pwm/pwm-meson.c @@ -162,12 +162,6 @@ static int meson_pwm_calc(struct meson_pwm *meson, struct pwm_device *pwm, duty = state->duty_cycle; period = state->period; - /* - * Note this is wrong. The result is an output wave that isn't really - * inverted and so is wrongly identified by .get_state as normal. - * Fixing this needs some care however as some machines might rely on - * this. - */ if (state->polarity == PWM_POLARITY_INVERSED) duty = period - duty; @@ -364,8 +358,6 @@ static int meson_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, state->duty_cycle = 0; } - state->polarity = PWM_POLARITY_NORMAL; - return 0; }