From b045498f5c40faf27485dcfa9429b8e73f9aa9ce Mon Sep 17 00:00:00 2001 From: Shawn Lin Date: Wed, 6 Dec 2023 17:13:18 +0800 Subject: [PATCH] arm64: dts: rockchip: enable emmc strobe line pulldown RK3399 SoC It's recommended to use internal pulldown, so we enable it via FW. However commit 8b5c2b45b8f0 ("phy: rockchip: set pulldown for strobe line in dts") disabled the pulldown settings if no dts property available. This breaks all the existing RK3399 boards without external strobe pulldown resistor. Fix is by adding rockchip,enable-strobe-pulldown to rk3399.dtsi Signed-off-by: Shawn Lin Change-Id: I510614e2029de293dfce48c78b1928244370b921 --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index d7290405dec6..e3692ce68c9d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi @@ -1707,6 +1707,7 @@ clock-names = "emmcclk"; drive-impedance-ohm = <50>; #phy-cells = <0>; + rockchip,enable-strobe-pulldown; status = "disabled"; };