shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-09 12:17:12 +09:00
Code Issues Packages Projects Releases Wiki Activity

inet: frags: get rif of inet_frag_evicting()

Browse Source 
commit 399d1404be upstream.

This refactors ip_expire() since one indentation level is removed.

Note: in the future, we should try hard to avoid the skb_clone()
since this is a serious performance cost.
Under DDOS, the ICMP message wont be sent because of rate limits.

Fact that ip6_expire_frag_queue() does not use skb_clone() is
disturbing too. Presumably IPv6 should have the same
issue than the one we fixed in commit ec4fbd6475
("inet: frag: release spinlock before calling icmp_send()")

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Mao Wenan <maowenan@huawei.com>
[bwh: Backported to 4.4: adjust context]
Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Eric Dumazet
2018-10-10 12:29:58 -07:00
committed by Greg Kroah-Hartman
parent cf2b9e68a6
commit b047c796de
3 changed files with 30 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
include/net/inet_frag.h
View File

@@ -118,11 +118,6 @@ static inline void inet_frag_put(struct inet_frag_queue *q)
inet_frag_destroy(q);
}
static inline bool inet_frag_evicting(struct inet_frag_queue *q)
{
return false;
}
/* Memory Tracking Functions. */
static inline int frag_mem_limit(struct netns_frags *nf)