shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-06 02:50:49 +09:00
Code Issues Packages Projects Releases Wiki Activity

sched/core: Report correct state for TASK_IDLE | TASK_FREEZABLE

Browse Source 
[ Upstream commit 0d6b35283b ]

task_state_index() ignores uninteresting state flags (such as
TASK_FREEZABLE) for most states, but for TASK_IDLE and TASK_RTLOCK_WAIT
it does not.

So if a task is waiting TASK_IDLE|TASK_FREEZABLE it gets incorrectly
reported as TASK_UNINTERRUPTIBLE or "D".  (it is planned for nfsd to
change to use this state).

Fix this by only testing the interesting bits and not the irrelevant
bits in __task_state_index()

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/169335025927.5133.4781141800413736103@noble.neil.brown.name
Stable-dep-of: f718faf3940e ("freezer, sched: Report frozen tasks as 'D' instead of 'R'")
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
NeilBrown
2023-08-30 09:04:19 +10:00
committed by Greg Kroah-Hartman
parent da719022a4
commit b0ce4e8fed
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/linux/sched.h
View File

@@ -1663,7 +1663,7 @@ static inline unsigned int __task_state_index(unsigned int tsk_state,
BUILD_BUG_ON_NOT_POWER_OF_2(TASK_REPORT_MAX); BUILD_BUG_ON_NOT_POWER_OF_2(TASK_REPORT_MAX);
if (tsk_state == TASK_IDLE) if ((tsk_state & TASK_IDLE) == TASK_IDLE)
state = TASK_REPORT_IDLE; state = TASK_REPORT_IDLE;
/* /*
@@ -1671,7 +1671,7 @@ static inline unsigned int __task_state_index(unsigned int tsk_state,
* to userspace, we can make this appear as if the task has gone through * to userspace, we can make this appear as if the task has gone through
* a regular rt_mutex_lock() call. * a regular rt_mutex_lock() call.
*/ */
if (tsk_state == TASK_RTLOCK_WAIT) if (tsk_state & TASK_RTLOCK_WAIT)
state = TASK_UNINTERRUPTIBLE; state = TASK_UNINTERRUPTIBLE;
return fls(state); return fls(state);