From b7d3db2ce23353c1a41ccf95432adf2878bf37bf Mon Sep 17 00:00:00 2001 From: Yangtao Li Date: Tue, 21 Mar 2023 01:31:36 +0800 Subject: [PATCH] f2fs: remove else in f2fs_write_cache_pages() As Christoph Hellwig point out: Please avoid the else by doing the goto in the branch. Signed-off-by: Yangtao Li Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 48ca0d974497..e71f0e9b5599 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -3093,11 +3093,9 @@ continue_unlock: } if (PageWriteback(page)) { - if (wbc->sync_mode != WB_SYNC_NONE) - f2fs_wait_on_page_writeback(page, - DATA, true, true); - else + if (wbc->sync_mode == WB_SYNC_NONE) goto continue_unlock; + f2fs_wait_on_page_writeback(page, DATA, true, true); } if (!clear_page_dirty_for_io(page))