shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-09 12:17:12 +09:00
Code Issues Packages Projects Releases Wiki Activity

net: stmmac: The netif_device_attach() should be called after napi_enable()

Browse Source 
If the netif_device_attach() is called earlier, the state of dev_queue is
waked, txtimer might be modified, and the txtimer is added at same time.
It might make run_timer_softirq crashed, because the timer is be detached
twice together.

Change-Id: I31dde4e940bddcc36372ca1f4a8313c0389d4e6b
Signed-off-by: David Wu <david.wu@rock-chips.com>
This commit is contained in:
David Wu
2017-04-28 17:41:43 +08:00
committed by Huang, Tao
parent ddb9616d29
commit b9ca500f21
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
View File

@@ -3110,8 +3110,6 @@ int stmmac_resume(struct net_device *ndev)
stmmac_mdio_reset(priv->mii);
}
netif_device_attach(ndev);
spin_lock_irqsave(&priv->lock, flags);
priv->cur_rx = 0;
@@ -3128,6 +3126,8 @@ int stmmac_resume(struct net_device *ndev)
netif_start_queue(ndev);
netif_device_attach(ndev);
spin_unlock_irqrestore(&priv->lock, flags);
if (priv->phydev)