From ba11b11d0b1611e148b157c0c19e45ca0a12e7d1 Mon Sep 17 00:00:00 2001 From: Jian Cao Date: Thu, 27 Jun 2019 14:20:46 +0800 Subject: [PATCH] ge2d: add return value check for kstrtoint call [1/1] PD#OTT-4875 Problem: missing return value check for kstrtoint Solution: add this check for kstrtoint Verify: verified on g12b-w400 Change-Id: I0515b4b445c78d950201df6547e83578cac32d16 Signed-off-by: Jian Cao --- drivers/amlogic/media/common/ge2d/ge2d_main.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/amlogic/media/common/ge2d/ge2d_main.c b/drivers/amlogic/media/common/ge2d/ge2d_main.c index 6481d9c3cbb8..48a5940e4a40 100644 --- a/drivers/amlogic/media/common/ge2d/ge2d_main.c +++ b/drivers/amlogic/media/common/ge2d/ge2d_main.c @@ -151,6 +151,11 @@ static ssize_t dump_reg_enable_store(struct class *cla, int ret = 0; ret = kstrtoint(buf, 0, &res); + if (ret) { + ge2d_log_err("kstrtoint err\n"); + return -EINVAL; + } + ge2d_log_info("ge2d dump_reg_enbale: %d->%d\n", ge2d_dump_reg_enable, res); ge2d_dump_reg_enable = res; @@ -173,6 +178,11 @@ static ssize_t dump_reg_cnt_store(struct class *cla, int ret = 0; ret = kstrtoint(buf, 0, &res); + if (ret) { + ge2d_log_err("kstrtoint err\n"); + return -EINVAL; + } + ge2d_log_info("ge2d dump_reg: %d->%d\n", ge2d_dump_reg_cnt, res); ge2d_dump_reg_cnt = res; return count; @@ -193,6 +203,11 @@ static ssize_t log_level_store(struct class *cla, int ret = 0; ret = kstrtoint(buf, 0, &res); + if (ret) { + ge2d_log_err("kstrtoint err\n"); + return -EINVAL; + } + ge2d_log_info("ge2d log_level: %d->%d\n", ge2d_log_level, res); ge2d_log_level = res;