shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-08 20:07:46 +09:00
Code Issues Packages Projects Releases Wiki Activity

PCI: hv: Fix wslot_to_devfn() to fix warnings on device removal

Browse Source 
commit 60e2e2fbaf upstream.

The devfn of 00:02.0 is 0x10.  devfn_to_wslot(0x10) == 0x2, and
wslot_to_devfn(0x2) should be 0x10, while it's 0x2 in the current code.

Due to this, hv_eject_device_work() -> pci_get_domain_bus_and_slot()
returns NULL and pci_stop_and_remove_bus_device() is not called.

Later when the real device driver's .remove() is invoked by
hv_pci_remove() -> pci_stop_root_bus(), some warnings can be noticed
because the VM has lost the access to the underlying device at that
time.

Signed-off-by: Jake Oshins <jakeo@microsoft.com>
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Haiyang Zhang <haiyangz@microsoft.com>
CC: K. Y. Srinivasan <kys@microsoft.com>
CC: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dexuan Cui
2017-02-10 15:18:46 -06:00
committed by Greg Kroah-Hartman
parent 787fd7a6c8
commit bc5338a4fd
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/pci/host/pci-hyperv.c
View File

@@ -130,7 +130,8 @@ union pci_version {
*/ */
union win_slot_encoding { union win_slot_encoding {
struct { struct {
u32 func:8; u32 dev:5;
u32 func:3;
u32 reserved:24; u32 reserved:24;
} bits; } bits;
u32 slot; u32 slot;
@@ -483,7 +484,8 @@ static u32 devfn_to_wslot(int devfn)
union win_slot_encoding wslot; union win_slot_encoding wslot;
wslot.slot = 0; wslot.slot = 0;
wslot.bits.func = PCI_SLOT(devfn) | (PCI_FUNC(devfn) << 5); wslot.bits.dev = PCI_SLOT(devfn);
wslot.bits.func = PCI_FUNC(devfn);
return wslot.slot; return wslot.slot;
} }
@@ -501,7 +503,7 @@ static int wslot_to_devfn(u32 wslot)
union win_slot_encoding slot_no; union win_slot_encoding slot_no;
slot_no.slot = wslot; slot_no.slot = wslot;
return PCI_DEVFN(0, slot_no.bits.func); return PCI_DEVFN(slot_no.bits.dev, slot_no.bits.func);
} }
/* /*