shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-10 21:07:02 +09:00
Code Issues Packages Projects Releases Wiki Activity

ksmbd: Convert to use sysfs_emit()/sysfs_emit_at() APIs

Browse Source 
[ Upstream commit 72ee45fd46 ]

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
ye xingchen
2023-12-19 00:33:28 +09:00
committed by Greg Kroah-Hartman
parent 46c517bc0a
commit bcab5c8105
1 changed files with 6 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
fs/ksmbd/server.c
View File

@@ -439,11 +439,9 @@ static ssize_t stats_show(struct class *class, struct class_attribute *attr,
"reset", "reset",
"shutdown" "shutdown"
}; };
return sysfs_emit(buf, "%d %s %d %lu\n", stats_version,
ssize_t sz = scnprintf(buf, PAGE_SIZE, "%d %s %d %lu\n", stats_version, state[server_conf.state], server_conf.tcp_port,
state[server_conf.state], server_conf.tcp_port, server_conf.ipc_last_active / HZ);
server_conf.ipc_last_active / HZ);
return sz;
} }
static ssize_t kill_server_store(struct class *class, static ssize_t kill_server_store(struct class *class,
@@ -475,19 +473,13 @@ static ssize_t debug_show(struct class *class, struct class_attribute *attr,
for (i = 0; i < ARRAY_SIZE(debug_type_strings); i++) { for (i = 0; i < ARRAY_SIZE(debug_type_strings); i++) {
if ((ksmbd_debug_types >> i) & 1) { if ((ksmbd_debug_types >> i) & 1) {
pos = scnprintf(buf + sz, pos = sysfs_emit_at(buf, sz, "[%s] ", debug_type_strings[i]);
PAGE_SIZE - sz,
"[%s] ",
debug_type_strings[i]);
} else { } else {
pos = scnprintf(buf + sz, pos = sysfs_emit_at(buf, sz, "%s ", debug_type_strings[i]);
PAGE_SIZE - sz,
"%s ",
debug_type_strings[i]);
} }
sz += pos; sz += pos;
} }
sz += scnprintf(buf + sz, PAGE_SIZE - sz, "\n"); sz += sysfs_emit_at(buf, sz, "\n");
return sz; return sz;
} }