From bd84eb0c8d49bcb432add9d7728988457430404e Mon Sep 17 00:00:00 2001 From: Shawn Lin Date: Mon, 9 Dec 2024 16:50:29 +0800 Subject: [PATCH] PCI: dw: rockchip: Fix s2r failure Before commit 7f84caccd038 ("PCI: dw: rockchip: Define IO and Host initialization interfaces"), ret is getting from rk_pcie_disable_power() which should never fail actually. Now the final ret is getting from phy_validate() which could return -EOPNOTSUPP. But we didn't care about it if phy_validate() isn't implemented. So we see: [ 13.573777] rk-pcie fe150000.pcie: PM: dpm_run_callback(): genpd_suspend_noirq+0x0/0x60 returns -95 [ 13.573800] rk-pcie fe150000.pcie: PM: failed to suspend async: error -95 Fix it by return zero to restore the previous behaviour. Fixes: 7f84caccd038 ("PCI: dw: rockchip: Define IO and Host initialization interfaces") Signed-off-by: Shawn Lin Change-Id: I0c7c858937272f2b09ba4ae79c0a68c7a633ced0 --- drivers/pci/controller/dwc/pcie-dw-rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c index 5b2ca47576de..d08aa7fbf031 100644 --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c @@ -1975,7 +1975,7 @@ no_l2: rk_pcie->in_suspend = true; - return ret; + return 0; } static int __maybe_unused rockchip_dw_pcie_resume(struct device *dev)