UPSTREAM: binder: change error code from postive to negative in binder_transaction

Depending on the context, the error return value
here (extra_buffers_size < added_size) should be
negative.

Acked-by: Martijn Coenen <maco@android.com>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201026110314.135481-1-zhangqilong3@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 88f6c77927)
Signed-off-by: Carlos Llamas <cmllamas@google.com>
Change-Id: If90760a8469f33bb121f0f71098b9415f6d4d783
This commit is contained in:
Zhang Qilong
2020-10-26 19:03:14 +08:00
committed by Todd Kjos
parent d4d78c7278
commit c383610d0f

View File

@@ -2892,7 +2892,7 @@ static void binder_transaction(struct binder_proc *proc,
if (extra_buffers_size < added_size) {
/* integer overflow of extra_buffers_size */
return_error = BR_FAILED_REPLY;
return_error_param = EINVAL;
return_error_param = -EINVAL;
return_error_line = __LINE__;
goto err_bad_extra_size;
}