From c544fe878d28105bcd952def1d056850d6a83d2e Mon Sep 17 00:00:00 2001 From: Jon Lin Date: Wed, 15 Feb 2023 14:35:41 +0800 Subject: [PATCH] PCI: rockchip: dw: Fix warning in initial progress 1.missing unwind goto 2.Value stored to 'ret' is never read Fixes: fa919e9611b4 ("pcie: rockchip: dw: Support dmatest") Change-Id: I20ae68b97a6512cbb340668b1ffb7811dc6ef674 Signed-off-by: Jon Lin --- drivers/pci/controller/dwc/pcie-dw-rockchip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c index 25a33e8252b4..696ce42b70a6 100644 --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c @@ -1319,8 +1319,8 @@ static int rk_pcie_phy_init(struct rk_pcie *rk_pcie) } if (rk_pcie->bifurcation) - ret = phy_set_mode_ext(rk_pcie->phy, rk_pcie->phy_mode, - PHY_MODE_PCIE_BIFURCATION); + phy_set_mode_ext(rk_pcie->phy, rk_pcie->phy_mode, + PHY_MODE_PCIE_BIFURCATION); ret = phy_init(rk_pcie->phy); if (ret < 0) { @@ -2111,7 +2111,7 @@ retry_regulator: ret = rk_pcie_init_dma_trx(rk_pcie); if (ret) { dev_err(dev, "failed to add dma extension\n"); - return ret; + goto remove_irq_domain; } if (rk_pcie->dma_obj) {