From c756c6b0943ddc56d966718eba35a9fec225b9aa Mon Sep 17 00:00:00 2001 From: Wolfram Sang Date: Wed, 10 Apr 2024 13:24:25 +0200 Subject: [PATCH] UPSTREAM: i2c: qcom-geni: remove printout on handled timeouts I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang Reviewed-by: Bjorn Andersson Signed-off-by: Andi Shyti Bug: 370629635 Change-Id: Ie1390ae6031913154eb152517f2f4e5147c5fe87 (cherry picked from commit 6d128e73c7820356a3481024166b9f3dc3aee99c) Signed-off-by: Praveen Talari --- drivers/i2c/busses/i2c-qcom-geni.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c index 5cc32a465f12..f09f91f2157d 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -630,11 +630,8 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev *gi2c, struct i2c_msg msgs[], i dma_async_issue_pending(gi2c->tx_c); timeout = wait_for_completion_timeout(&gi2c->done, XFER_TIMEOUT); - if (!timeout) { - dev_err(gi2c->se.dev, "I2C timeout gpi flags:%d addr:0x%x\n", - gi2c->cur->flags, gi2c->cur->addr); + if (!timeout) gi2c->err = -ETIMEDOUT; - } if (gi2c->err) { ret = gi2c->err;