From d088c2e8a7fc224ccd1610fb58d91f99975f4ee7 Mon Sep 17 00:00:00 2001 From: Finley Xiao Date: Mon, 6 Jun 2022 14:08:51 +0800 Subject: [PATCH] driver: rknpu: Add missing error code in npu_opp_helper() Fixes: b6b135b2f672 ("driver: rknpu: Change clock rate and read margin only when pd is on") Signed-off-by: Finley Xiao Change-Id: If4fc249f86d6f406157944afabee477908a56fa1 --- drivers/rknpu/rknpu_drv.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/rknpu/rknpu_drv.c b/drivers/rknpu/rknpu_drv.c index f0c817c92bbf..0aa5add1e4d3 100644 --- a/drivers/rknpu/rknpu_drv.c +++ b/drivers/rknpu/rknpu_drv.c @@ -820,7 +820,8 @@ static int npu_opp_helper(struct dev_pm_set_opp_data *data) } rockchip_set_read_margin(dev, opp_info, target_rm, is_set_rm); if (is_set_clk && clk_set_rate(clk, new_freq)) { - LOG_DEV_ERROR(dev, "failed to set clk rate: %d\n", ret); + ret = -EINVAL; + LOG_DEV_ERROR(dev, "failed to set clk rate\n"); goto restore_rm; } /* Scaling down? Scale voltage after frequency */ @@ -829,7 +830,8 @@ static int npu_opp_helper(struct dev_pm_set_opp_data *data) new_freq, false, is_set_clk); rockchip_set_read_margin(dev, opp_info, target_rm, is_set_rm); if (is_set_clk && clk_set_rate(clk, new_freq)) { - LOG_DEV_ERROR(dev, "failed to set clk rate: %d\n", ret); + ret = -EINVAL; + LOG_DEV_ERROR(dev, "failed to set clk rate\n"); goto restore_rm; } ret = regulator_set_voltage(vdd_reg, new_supply_vdd->u_volt,