shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-08 20:07:46 +09:00
Code Issues Packages Projects Releases Wiki Activity

rpmsg: Fix possible refcount leak in rpmsg_register_device_override()

Browse Source 
commit d7bd416d35 upstream.

rpmsg_register_device_override need to call put_device to free vch when
driver_set_override fails.

Fix this by adding a put_device() to the error path.

Fixes: bb17d110cb ("rpmsg: Fix calling device_lock() on non-initialized device")
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Link: https://lore.kernel.org/r/20220624024120.11576-1-hbh25y@gmail.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Hangyu Hua
2023-10-31 11:25:40 +00:00
committed by Greg Kroah-Hartman
parent a82e0fda8a
commit d4c8bf5635
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/rpmsg/rpmsg_core.c
View File

@@ -594,6 +594,7 @@ int rpmsg_register_device_override(struct rpmsg_device *rpdev,
strlen(driver_override)); strlen(driver_override));
if (ret) { if (ret) {
dev_err(dev, "device_set_override failed: %d\n", ret); dev_err(dev, "device_set_override failed: %d\n", ret);
put_device(dev);
return ret; return ret;
} }
} }