mirror of
https://github.com/hardkernel/linux.git
synced 2026-03-25 12:00:22 +09:00
bnxt: avoid overflow in bnxt_get_nvram_directory()
[ Upstream commit 7c6dddc239 ]
The value of an arithmetic expression is subject
of possible overflow due to a failure to cast operands to a larger data
type before performing arithmetic. Used macro for multiplication instead
operator for avoiding overflow.
Found by Security Code and Linux Verification
Center (linuxtesting.org) with SVACE.
Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Link: https://lore.kernel.org/r/20230309174347.3515-1-korotkov.maxim.s@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
f910374870
commit
d5eaf2a6b0
@@ -2709,7 +2709,7 @@ static int bnxt_get_nvram_directory(struct net_device *dev, u32 len, u8 *data)
|
||||
if (rc)
|
||||
return rc;
|
||||
|
||||
buflen = dir_entries * entry_length;
|
||||
buflen = mul_u32_u32(dir_entries, entry_length);
|
||||
buf = hwrm_req_dma_slice(bp, req, buflen, &dma_handle);
|
||||
if (!buf) {
|
||||
hwrm_req_drop(bp, req);
|
||||
|
||||
Reference in New Issue
Block a user