From b8c0e6975da7dc650eeb8382e945f47477a629ae Mon Sep 17 00:00:00 2001 From: YouMin Chen Date: Tue, 22 Apr 2025 16:41:07 +0800 Subject: [PATCH 1/2] firmware: rockchip_sip: add valid value check for map->bank_bit_first Change-Id: I4909cd313854a10c415686f3c9df85411677370d Signed-off-by: YouMin Chen --- drivers/firmware/rockchip_sip.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/firmware/rockchip_sip.c b/drivers/firmware/rockchip_sip.c index 8a2e82c73fde..3cebfa46befe 100644 --- a/drivers/firmware/rockchip_sip.c +++ b/drivers/firmware/rockchip_sip.c @@ -211,28 +211,29 @@ struct dram_addrmap_info *sip_smc_get_dram_map(void) { struct arm_smccc_res res; static struct dram_addrmap_info *map; + struct dram_addrmap_info *m; if (map) - return map; + return map->bank_bit_first ? map : NULL; /* Request share memory size 4KB */ res = sip_smc_request_share_mem(1, SHARE_PAGE_TYPE_DDR_ADDRMAP); if (res.a0 != 0) { - pr_err("no ATF memory for init\n"); + pr_err("%s: request share memory error!\n", __func__); return NULL; } - - map = (struct dram_addrmap_info *)res.a1; + m = (struct dram_addrmap_info *)res.a1; + memset(m, 0x0, sizeof(*m)); res = sip_smc_dram(SHARE_PAGE_TYPE_DDR_ADDRMAP, 0, ROCKCHIP_SIP_CONFIG_DRAM_ADDRMAP_GET); if (res.a0) { - pr_err("rockchip_sip_config_dram_init error:%lx\n", res.a0); - map = NULL; + pr_err("rockchip_sip_config_dram_addrmap_get error:%lx\n", res.a0); return NULL; } + map = m; - return map; + return map->bank_bit_first ? map : NULL; } EXPORT_SYMBOL_GPL(sip_smc_get_dram_map); From e1d516524cf376f1a87f089b742793840587e4ec Mon Sep 17 00:00:00 2001 From: Tao Huang Date: Wed, 23 Apr 2025 20:07:54 +0800 Subject: [PATCH 2/2] clk: rockchip: Add missing MODULE_LICENSE() ERROR: modpost: missing MODULE_LICENSE() in drivers/clk/rockchip/clk-rockchip.o Signed-off-by: Tao Huang Change-Id: I875c24b00995e955056eea03a048d54032085590 --- drivers/clk/rockchip/clk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c index c716d4177e59..2b9bdc8b1a32 100644 --- a/drivers/clk/rockchip/clk.c +++ b/drivers/clk/rockchip/clk.c @@ -836,4 +836,6 @@ void rockchip_clk_disable_unused(void) } } EXPORT_SYMBOL_GPL(rockchip_clk_disable_unused); + +MODULE_LICENSE("GPL"); #endif /* MODULE */