shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-05 10:31:46 +09:00
Code Issues Packages Projects Releases Wiki Activity

nvmet: prevent sprintf() overflow in nvmet_subsys_nsid_exists()

Browse Source 
[ Upstream commit d15dcd0f1a4753b57e66c64c8dc2a9779ff96aab ]

The nsid value is a u32 that comes from nvmet_req_find_ns().  It's
endian data and we're on an error path and both of those raise red
flags.  So let's make this safer.

1) Make the buffer large enough for any u32.
2) Remove the unnecessary initialization.
3) Use snprintf() instead of sprintf() for even more safety.
4) The sprintf() function returns the number of bytes printed, not
   counting the NUL terminator. It is impossible for the return value to
   be <= 0 so delete that.

Fixes: 505363957fad ("nvmet: fix nvme status code when namespace is disabled")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dan Carpenter
2024-05-08 10:43:04 +03:00
committed by Greg Kroah-Hartman
parent 559214eb4e
commit de9bf32eab
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/nvme/target/configfs.c
View File

@@ -618,10 +618,9 @@ static struct configfs_attribute *nvmet_ns_attrs[] = {
bool nvmet_subsys_nsid_exists(struct nvmet_subsys *subsys, u32 nsid) bool nvmet_subsys_nsid_exists(struct nvmet_subsys *subsys, u32 nsid)
{ {
struct config_item *ns_item; struct config_item *ns_item;
char name[4] = {}; char name[12];
if (sprintf(name, "%u", nsid) <= 0) snprintf(name, sizeof(name), "%u", nsid);
return false;
mutex_lock(&subsys->namespaces_group.cg_subsys->su_mutex); mutex_lock(&subsys->namespaces_group.cg_subsys->su_mutex);
ns_item = config_group_find_item(&subsys->namespaces_group, name); ns_item = config_group_find_item(&subsys->namespaces_group, name);
mutex_unlock(&subsys->namespaces_group.cg_subsys->su_mutex); mutex_unlock(&subsys->namespaces_group.cg_subsys->su_mutex);