shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-05 10:31:46 +09:00
Code Issues Packages Projects Releases Wiki Activity

phy: lynx-28g: lock PHY while performing CDR lock workaround

Browse Source 
[ Upstream commit 0ac87fe54a ]

lynx_28g_cdr_lock_check() runs once per second in a workqueue to reset
the lane receiver if the CDR has not locked onto bit transitions in the
RX stream. But the PHY consumer may do stuff with the PHY simultaneously,
and that isn't okay. Block concurrent generic PHY calls by holding the
PHY mutex from this workqueue.

Fixes: 8f73b37cf3 ("phy: add support for the Layerscape SerDes 28G")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Vladimir Oltean
2023-10-04 14:17:07 +03:00
committed by Greg Kroah-Hartman
parent e52c81a9e3
commit e173d9a2e5
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/phy/freescale/phy-fsl-lynx-28g.c
View File

@@ -507,11 +507,12 @@ static void lynx_28g_cdr_lock_check(struct work_struct *work)
for (i = 0; i < LYNX_28G_NUM_LANE; i++) { for (i = 0; i < LYNX_28G_NUM_LANE; i++) {
lane = &priv->lane[i]; lane = &priv->lane[i];
if (!lane->init) mutex_lock(&lane->phy->mutex);
continue;
if (!lane->powered_up) if (!lane->init || !lane->powered_up) {
mutex_unlock(&lane->phy->mutex);
continue; continue;
}
rrstctl = lynx_28g_lane_read(lane, LNaRRSTCTL); rrstctl = lynx_28g_lane_read(lane, LNaRRSTCTL);
if (!(rrstctl & LYNX_28G_LNaRRSTCTL_CDR_LOCK)) { if (!(rrstctl & LYNX_28G_LNaRRSTCTL_CDR_LOCK)) {
@@ -520,6 +521,8 @@ static void lynx_28g_cdr_lock_check(struct work_struct *work)
rrstctl = lynx_28g_lane_read(lane, LNaRRSTCTL); rrstctl = lynx_28g_lane_read(lane, LNaRRSTCTL);
} while (!(rrstctl & LYNX_28G_LNaRRSTCTL_RST_DONE)); } while (!(rrstctl & LYNX_28G_LNaRRSTCTL_RST_DONE));
} }
mutex_unlock(&lane->phy->mutex);
} }
queue_delayed_work(system_power_efficient_wq, &priv->cdr_check, queue_delayed_work(system_power_efficient_wq, &priv->cdr_check,
msecs_to_jiffies(1000)); msecs_to_jiffies(1000));