From e206a3aee7ac2743e5ed5cc6da306ce1dd1f0044 Mon Sep 17 00:00:00 2001 From: Sandy Huang Date: Thu, 4 Jul 2019 14:09:42 +0800 Subject: [PATCH] drm/panel: Don't init gpio value at probe When enable display on loader, init gpio would change gpio status, that would make screen flash. Change-Id: I4b69a8d3d83c5bef09014c2134abaee6522a7046 Signed-off-by: Mark Yao Signed-off-by: Sandy Huang --- drivers/gpu/drm/panel/panel-simple.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 3486431dd935..e1ce416ea630 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -252,7 +252,7 @@ static int panel_simple_unprepare(struct drm_panel *panel) if (!p->prepared) return 0; - gpiod_set_value_cansleep(p->enable_gpio, 0); + gpiod_direction_output(p->enable_gpio, 0); panel_simple_regulator_disable(panel); @@ -278,7 +278,7 @@ static int panel_simple_prepare(struct drm_panel *panel) return err; } - gpiod_set_value_cansleep(p->enable_gpio, 1); + gpiod_direction_output(p->enable_gpio, 1); if (p->desc->delay.prepare) msleep(p->desc->delay.prepare); @@ -376,7 +376,7 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) return PTR_ERR(panel->supply); panel->enable_gpio = devm_gpiod_get_optional(dev, "enable", - GPIOD_OUT_LOW); + GPIOD_ASIS); if (IS_ERR(panel->enable_gpio)) { err = PTR_ERR(panel->enable_gpio); if (err != -EPROBE_DEFER)