From e58f2f0f0527d29448a856ba35be113158236bdc Mon Sep 17 00:00:00 2001 From: Sandy Huang Date: Fri, 8 Dec 2023 16:35:32 +0800 Subject: [PATCH] drm/rockchip: vop2: add some debug info for ignored crtc For RK356X/RK3588, the VP plane_mask be 0 will have the following two case: 1. The VP is disabled; 2. For some mistake, the VP is enabled but the plane_mask is 0; This will lead to this crtc register be ignored, So add a few reminders log. Signed-off-by: Sandy Huang Change-Id: Ia49db3051e651095350aeba9c2a27ac7086fe06b --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c index ff5c26f7b746..b48153442e25 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -11300,11 +11300,13 @@ static int vop2_create_crtc(struct vop2 *vop2) possible_crtcs = BIT(registered_num_crtcs); /* - * we assume a vp with a zere plane_mask(set from dts or bootloader) + * we assume a vp with a zero plane_mask(set from dts or bootloader) * as unused. */ - if (!vp->plane_mask && bootloader_initialized) + if (!vp->plane_mask && bootloader_initialized) { + DRM_DEV_INFO(vop2->dev, "VP%d plane_mask is zero, so ignore register crtc\n", vp->id); continue; + } if (vop2_soc_is_rk3566()) soc_id = vp_data->soc_id[1];