From e8d401ee32a6b1a8dcd877879448c9750b93864b Mon Sep 17 00:00:00 2001 From: Damon Ding Date: Mon, 1 Jul 2024 15:25:39 +0800 Subject: [PATCH] pwm: rockchip-test: get counter result before disabled in pwm test demo The counter result read after disabled may be inaccurate, because the arbitration has been removed. Change-Id: Id91069721ef5767d81bb8bced0ae429840711ad4 Signed-off-by: Damon Ding --- drivers/pwm/pwm-rockchip-test.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pwm/pwm-rockchip-test.c b/drivers/pwm/pwm-rockchip-test.c index ca8dc514664e..59294260298d 100644 --- a/drivers/pwm/pwm-rockchip-test.c +++ b/drivers/pwm/pwm-rockchip-test.c @@ -490,16 +490,16 @@ static ssize_t pwm_rockchip_test_write(struct file *file, const char __user *buf msleep(timeout_ms); - ret = rockchip_pwm_set_counter(pdev, 0, false); + ret = rockchip_pwm_get_counter_result(pdev, &counter_res, true); if (ret) { - pr_err("failed to disable %s mode for pwm%d_%d\n", + pr_err("failed to get %s mode result for pwm%d_%d\n", cmd, controller_id, channel_id); return -EINVAL; } - ret = rockchip_pwm_get_counter_result(pdev, &counter_res, true); + ret = rockchip_pwm_set_counter(pdev, 0, false); if (ret) { - pr_err("failed to get %s mode result for pwm%d_%d\n", + pr_err("failed to disable %s mode for pwm%d_%d\n", cmd, controller_id, channel_id); return -EINVAL; }