shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-05 10:31:46 +09:00
Code Issues Packages Projects Releases Wiki Activity

btrfs: error when COWing block from a root that is being deleted

Browse Source 
[ Upstream commit a2caab2988 ]

At btrfs_cow_block() we check if the block being COWed belongs to a root
that is being deleted and if so we log an error message. However this is
an unexpected case and it indicates a bug somewhere, so we should return
an error and abort the transaction. So change this in the following ways:

1) Abort the transaction with -EUCLEAN, so that if the issue ever happens
   it can easily be noticed;

2) Change the logged message level from error to critical, and change the
   message itself to print the block's logical address and the ID of the
   root;

3) Return -EUCLEAN to the caller;

4) As this is an unexpected scenario, that should never happen, mark the
   check as unlikely, allowing the compiler to potentially generate better
   code.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Filipe Manana
2023-09-27 12:09:22 +01:00
committed by Greg Kroah-Hartman
parent c833f1e28d
commit f174c8d2c6
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
fs/btrfs/ctree.c
View File

@@ -563,9 +563,13 @@ noinline int btrfs_cow_block(struct btrfs_trans_handle *trans,
u64 search_start; u64 search_start;
int ret; int ret;
if (test_bit(BTRFS_ROOT_DELETING, &root->state)) if (unlikely(test_bit(BTRFS_ROOT_DELETING, &root->state))) {
btrfs_err(fs_info, btrfs_abort_transaction(trans, -EUCLEAN);
"COW'ing blocks on a fs root that's being dropped"); btrfs_crit(fs_info,
"attempt to COW block %llu on root %llu that is being deleted",
buf->start, btrfs_root_id(root));
return -EUCLEAN;
}
/* /*
* COWing must happen through a running transaction, which always * COWing must happen through a running transaction, which always