shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-05 18:41:58 +09:00
Code Issues Packages Projects Releases Wiki Activity

dmaengine: dw-edma: Fix to change for continuous transfer

Browse Source 
[ Upstream commit a251994a44 ]

The dw-edma driver stops after processing a DMA request even if a request
remains in the issued queue, which is not the expected behavior. The DMA
engine API requires continuous processing.

Add a trigger to start after one processing finished if there are requests
remain.

Fixes: e63d79d1ff ("dmaengine: Add Synopsys eDMA IP core driver")
Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
Link: https://lore.kernel.org/r/20230411101758.438472-1-mie@igel.co.jp
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Shunsuke Mie
2023-04-11 19:17:57 +09:00
committed by Greg Kroah-Hartman
parent dd23c11136
commit fd6316dec2
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/dma/dw-edma/dw-edma-core.c
View File

@@ -171,7 +171,7 @@ static void vchan_free_desc(struct virt_dma_desc *vdesc)
dw_edma_free_desc(vd2dw_edma_desc(vdesc)); dw_edma_free_desc(vd2dw_edma_desc(vdesc));
} }
static void dw_edma_start_transfer(struct dw_edma_chan *chan) static int dw_edma_start_transfer(struct dw_edma_chan *chan)
{ {
struct dw_edma_chunk *child; struct dw_edma_chunk *child;
struct dw_edma_desc *desc; struct dw_edma_desc *desc;
@@ -179,16 +179,16 @@ static void dw_edma_start_transfer(struct dw_edma_chan *chan)
vd = vchan_next_desc(&chan->vc); vd = vchan_next_desc(&chan->vc);
if (!vd) if (!vd)
return; return 0;
desc = vd2dw_edma_desc(vd); desc = vd2dw_edma_desc(vd);
if (!desc) if (!desc)
return; return 0;
child = list_first_entry_or_null(&desc->chunk->list, child = list_first_entry_or_null(&desc->chunk->list,
struct dw_edma_chunk, list); struct dw_edma_chunk, list);
if (!child) if (!child)
return; return 0;
dw_edma_v0_core_start(child, !desc->xfer_sz); dw_edma_v0_core_start(child, !desc->xfer_sz);
desc->xfer_sz += child->ll_region.sz; desc->xfer_sz += child->ll_region.sz;
@@ -196,6 +196,8 @@ static void dw_edma_start_transfer(struct dw_edma_chan *chan)
list_del(&child->list); list_del(&child->list);
kfree(child); kfree(child);
desc->chunks_alloc--; desc->chunks_alloc--;
return 1;
} }
static int dw_edma_device_config(struct dma_chan *dchan, static int dw_edma_device_config(struct dma_chan *dchan,
@@ -555,14 +557,14 @@ static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
switch (chan->request) { switch (chan->request) {
case EDMA_REQ_NONE: case EDMA_REQ_NONE:
desc = vd2dw_edma_desc(vd); desc = vd2dw_edma_desc(vd);
if (desc->chunks_alloc) { if (!desc->chunks_alloc) {
chan->status = EDMA_ST_BUSY;
dw_edma_start_transfer(chan);
} else {
list_del(&vd->node); list_del(&vd->node);
vchan_cookie_complete(vd); vchan_cookie_complete(vd);
chan->status = EDMA_ST_IDLE;
} }
/* Continue transferring if there are remaining chunks or issued requests.
*/
chan->status = dw_edma_start_transfer(chan) ? EDMA_ST_BUSY : EDMA_ST_IDLE;
break; break;
case EDMA_REQ_STOP: case EDMA_REQ_STOP: