Arvind Sankar
c5ff734cf6
arch/s390/setup: Drop dummy_con initialization
...
con_init in tty/vt.c will now set conswitchp to dummy_con if it's unset.
Drop it from arch setup code.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu >
Link: https://lore.kernel.org/r/20191218214506.49252-20-nivedita@alum.mit.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:29:18 +01:00
Arvind Sankar
2680e04c18
arch/riscv/setup: Drop dummy_con initialization
...
con_init in tty/vt.c will now set conswitchp to dummy_con if it's unset.
Drop it from arch setup code.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu >
Link: https://lore.kernel.org/r/20191218214506.49252-19-nivedita@alum.mit.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:29:18 +01:00
Arvind Sankar
4c82266d15
arch/powerpc/setup: Drop dummy_con initialization
...
con_init in tty/vt.c will now set conswitchp to dummy_con if it's unset.
Drop it from arch setup code.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu >
Link: https://lore.kernel.org/r/20191218214506.49252-18-nivedita@alum.mit.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:29:17 +01:00
Arvind Sankar
82292aaede
arch/parisc/setup: Drop dummy_con initialization
...
con_init in tty/vt.c will now set conswitchp to dummy_con if it's unset.
Drop it from arch setup code.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu >
Link: https://lore.kernel.org/r/20191218214506.49252-17-nivedita@alum.mit.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:29:17 +01:00
Arvind Sankar
bd3b0677cb
arch/openrisc/setup: Drop dummy_con initialization
...
con_init in tty/vt.c will now set conswitchp to dummy_con if it's unset.
Drop it from arch setup code.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu >
Link: https://lore.kernel.org/r/20191218214506.49252-16-nivedita@alum.mit.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:29:17 +01:00
Arvind Sankar
701250223c
arch/nios2/setup: Drop dummy_con initialization
...
con_init in tty/vt.c will now set conswitchp to dummy_con if it's unset.
Drop it from arch setup code.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu >
Link: https://lore.kernel.org/r/20191218214506.49252-15-nivedita@alum.mit.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:29:17 +01:00
Arvind Sankar
4b15a5b205
arch/nds32/setup: Drop dummy_con initialization
...
con_init in tty/vt.c will now set conswitchp to dummy_con if it's unset.
Drop it from arch setup code.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu >
Link: https://lore.kernel.org/r/20191218214506.49252-14-nivedita@alum.mit.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:29:17 +01:00
Arvind Sankar
3229af4f3e
arch/mips/setup: Drop dummy_con initialization
...
con_init in tty/vt.c will now set conswitchp to dummy_con if it's unset.
Drop it from arch setup code.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu >
Link: https://lore.kernel.org/r/20191218214506.49252-13-nivedita@alum.mit.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:29:16 +01:00
Arvind Sankar
4946d6cc01
arch/microblaze/setup: Drop dummy_con initialization
...
con_init in tty/vt.c will now set conswitchp to dummy_con if it's unset.
Drop it from arch setup code.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu >
Link: https://lore.kernel.org/r/20191218214506.49252-12-nivedita@alum.mit.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:29:16 +01:00
Arvind Sankar
143c2ce261
arch/m68k/setup: Drop dummy_con initialization
...
con_init in tty/vt.c will now set conswitchp to dummy_con if it's unset.
Drop it from arch setup code.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu >
Link: https://lore.kernel.org/r/20191218214506.49252-11-nivedita@alum.mit.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:29:16 +01:00
Arvind Sankar
6b448f12a2
arch/ia64/setup: Drop dummy_con initialization
...
con_init in tty/vt.c will now set conswitchp to dummy_con if it's unset.
Drop it from arch setup code.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu >
Link: https://lore.kernel.org/r/20191218214506.49252-10-nivedita@alum.mit.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:29:16 +01:00
Arvind Sankar
fb3e7a6220
arch/csky/setup: Drop dummy_con initialization
...
con_init in tty/vt.c will now set conswitchp to dummy_con if it's unset.
Drop it from arch setup code.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu >
Link: https://lore.kernel.org/r/20191218214506.49252-9-nivedita@alum.mit.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:29:16 +01:00
Arvind Sankar
46cbe2f399
arch/arm64/setup: Drop dummy_con initialization
...
con_init in tty/vt.c will now set conswitchp to dummy_con if it's unset.
Drop it from arch setup code.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu >
Link: https://lore.kernel.org/r/20191218214506.49252-7-nivedita@alum.mit.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:29:15 +01:00
Arvind Sankar
3e70ac0691
arch/arm/setup: Drop dummy_con initialization
...
con_init in tty/vt.c will now set conswitchp to dummy_con if it's unset.
Drop it from arch setup code.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu >
Link: https://lore.kernel.org/r/20191218214506.49252-6-nivedita@alum.mit.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:29:15 +01:00
Arvind Sankar
61f23e657c
arch/arc/setup: Drop dummy_con initialization
...
con_init in tty/vt.c will now set conswitchp to dummy_con if it's unset.
Drop it from arch setup code.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu >
Link: https://lore.kernel.org/r/20191218214506.49252-5-nivedita@alum.mit.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:29:15 +01:00
Arvind Sankar
9ef497dcbc
arch/alpha/setup: Drop dummy_con initialization
...
con_init in tty/vt.c will now set conswitchp to dummy_con if it's unset.
Drop it from arch setup code.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu >
Link: https://lore.kernel.org/r/20191218214506.49252-4-nivedita@alum.mit.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:29:15 +01:00
Arvind Sankar
805ece2a58
vt: Initialize conswitchp to dummy_con if unset
...
If the arch setup code hasn't initialized conswitchp yet, set it to
dummy_con in con_init. This will allow us to drop the dummy_con
initialization that's done in almost every architecture.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu >
Link: https://lore.kernel.org/r/20191218214506.49252-3-nivedita@alum.mit.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:29:15 +01:00
Arvind Sankar
e018bc28b0
console/dummycon: Remove bogus depends on from DUMMY_CONSOLE
...
Since commit [1] consolidated console configuration in
drivers/video/console, DUMMY_CONSOLE has always been enabled, since the
dependency is always satisfied.
There is no point in trying to allow it to be configured out, since
(a) it's tiny, and (b) if VT_CONSOLE is enabled, we must have a working
console driver by the time con_init(vt.c) runs, and only dummycon is
guaranteed to work (vgacon may be configured in, but that doesn't mean
we have a VGA device).
So just remove the fake dependency.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/commit?id=31d2a7d36d6989c714b792ec00358ada24c039e7
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu >
Link: https://lore.kernel.org/r/20191218214506.49252-2-nivedita@alum.mit.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:29:15 +01:00
Oscar Ravadilla
34bc4f468a
uio: uio_pdrv_genirq: Do not log an error when deferring probe routine.
...
When deferring the probe routine just return without displaying an
error.
Signed-off-by: Oscar Ravadilla <oscar.ravadilla@alliedtelesis.co.nz >
Link: https://lore.kernel.org/r/20200108001648.2949-1-oscar.ravadilla@alliedtelesis.co.nz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:27:51 +01:00
Jia-Ju Bai
b74351287d
uio: fix a sleep-in-atomic-context bug in uio_dmem_genirq_irqcontrol()
...
The driver may sleep while holding a spinlock.
The function call path (from bottom to top) in Linux 4.19 is:
kernel/irq/manage.c, 523:
synchronize_irq in disable_irq
drivers/uio/uio_dmem_genirq.c, 140:
disable_irq in uio_dmem_genirq_irqcontrol
drivers/uio/uio_dmem_genirq.c, 134:
_raw_spin_lock_irqsave in uio_dmem_genirq_irqcontrol
synchronize_irq() can sleep at runtime.
To fix this bug, disable_irq() is called without holding the spinlock.
This bug is found by a static analysis tool STCheck written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com >
Link: https://lore.kernel.org/r/20191218094405.6009-1-baijiaju1990@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:27:51 +01:00
Luc Van Oostenryck
fa4e7fc138
misc: xilinx_sdfec: fix xsdfec_poll()'s return type
...
xsdfec_poll() is defined as returning 'unsigned int' but the
.poll method is declared as returning '__poll_t', a bitwise type.
Fix this by using the proper return type and using the EPOLL
constants instead of the POLL ones, as required for __poll_t.
CC: Derek Kiernan <derek.kiernan@xilinx.com >
CC: Dragan Cvetic <dragan.cvetic@xilinx.com >
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com >
Acked-by: Dragan Cvetic <dragan.cvetic@xilinx.com >
Link: https://lore.kernel.org/r/20191209213655.57985-1-luc.vanoostenryck@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:16:51 +01:00
Luc Van Oostenryck
a6b07e89fd
misc: xilinx_sdfec: add missing __user annotation
...
The second arg of xsdfec_set_order() is a 'void __user *'
and this pointer is then used in get_user() which expect
a __user pointer.
But get_user() can't be used with a void pointer, it a
pointer to the effective type. This is done here by casting
the argument to a pointer to the effective type but the
__user is missing in the cast.
Fix this by adding the missing __user in the cast.
CC: Derek Kiernan <derek.kiernan@xilinx.com >
CC: Dragan Cvetic <dragan.cvetic@xilinx.com >
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com >
Acked-by: Dragan Cvetic <dragan.cvetic@xilinx.com >
Link: https://lore.kernel.org/r/20191209213719.58037-1-luc.vanoostenryck@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:16:51 +01:00
Colin Ian King
b0bd9ae346
drivers/misc: ti-st: remove redundant assignment to variables i and flags
...
The variables i and flags are being initialized with values that are
never read. The initializations are redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com >
Link: https://lore.kernel.org/r/20200113123149.187555-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:16:51 +01:00
Colin Ian King
f896ee51b9
misc: tsl2550: remove redundant initialization to variable r
...
The variable r is being initialized with a value that is never
read and it is being updated later with a new value. Remove
the redundant initialization and move the declaration into a
deeper code block.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com >
Link: https://lore.kernel.org/r/20200107175234.121298-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:16:51 +01:00
Colin Ian King
b5a0d4bf2e
misc: pti: remove redundant assignments to retval
...
The variable retval is assigned with a value that is never read and
it is re-assigned a new value later on. The assignment is redundant
and can be removed. Clean up multiple occurrances of this pattern.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com >
Link: https://lore.kernel.org/r/20191222222224.732340-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:16:51 +01:00
Rhys Perry
444972b2b2
misc: alcor_pci: Add AU6625 to list of supported PCI_IDs
...
I have added the AU6625 PCI_ID to the list of supported IDs:
alcor_pci.c
// Added au6625s ID to the array of supported devices
alcor_pci.h
// Added entry to define the PCI ID
Made it fit in with the already submitted code:
alcor_pci.c
// Added config entry to that matches the one for au6601
>From general usage there seems to be no problems.
Signed-off-by: Rhys Perry <rhysperry111@gmail.com >
Link: https://lore.kernel.org/r/20191229171824.10308-1-rhysperry111@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:16:50 +01:00
Julia Lawall
e10e024643
misc: cxl: use mmgrab
...
Mmgrab was introduced in commit f1f1007644 ("mm: add new mmgrab()
helper") and most of the kernel was updated to use it. Update a
remaining file.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/ )
<smpl>
@@ expression e; @@
- atomic_inc(&e->mm_count);
+ mmgrab(e);
</smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr >
Acked-by: Andrew Donnellan <ajd@linux.ibm.com >
Link: https://lore.kernel.org/r/1577634178-22530-2-git-send-email-Julia.Lawall@inria.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:16:50 +01:00
zhenwei pi
191941692a
misc: pvpanic: add crash loaded event
...
Some users prefer kdump tools to generate guest kernel dumpfile,
at the same time, need a out-of-band kernel panic event.
Currently if booting guest kernel with 'crash_kexec_post_notifiers',
QEMU will receive PVPANIC_PANICKED event and stop VM. If booting
guest kernel without 'crash_kexec_post_notifiers', guest will not
call notifier chain.
Add PVPANIC_CRASH_LOADED bit for pvpanic event, it means that guest
kernel actually hit a kernel panic, but the guest kernel wants to
handle by itself.
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com >
Link: https://lore.kernel.org/r/20200102023513.318836-3-pizhenwei@bytedance.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:07:37 +01:00
zhenwei pi
e0b9a42735
misc: pvpanic: move bit definition to uapi header file
...
Some processes outside of the kernel(Ex, QEMU) should know what the
value really is for, so move the bit definition to a uapi file.
Suggested-by: Greg KH <gregkh@linuxfoundation.org >
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com >
Link: https://lore.kernel.org/r/20200102023513.318836-2-pizhenwei@bytedance.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:07:37 +01:00
Claudiu Beznea
523752d8da
dt-bindings: atmel-gpbr: add microchip,sam9x60-gpbr
...
Add microchip,sam9x60-gpbr to DT bindings documentation.
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com >
Acked-by: Rob Herring <robh@kernel.org >
Link: https://lore.kernel.org/r/1578673089-3484-12-git-send-email-claudiu.beznea@microchip.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2020-01-14 15:06:57 +01:00
Claudiu Beznea
e517d6d949
dt-bindings: atmel-smc: add microchip,sam9x60-smc
...
Add microchip,sam9x60-smc to DT bindings documentation.
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com >
Acked-by: Rob Herring <robh@kernel.org >
Link: https://lore.kernel.org/r/1578673089-3484-11-git-send-email-claudiu.beznea@microchip.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2020-01-14 15:06:57 +01:00
Claudiu Beznea
ac9168dfba
dt-bindings: atmel-sysreg: add microchip,sam9x60-ddramc
...
Add microchip,sam9x60-ddramc to DT bindings documentation.
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com >
Acked-by: Rob Herring <robh@kernel.org >
Link: https://lore.kernel.org/r/1578673089-3484-10-git-send-email-claudiu.beznea@microchip.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2020-01-14 15:06:57 +01:00
Claudiu Beznea
7402b7fa48
dt-bindings: atmel-nand: add microchip,sam9x60-pmecc
...
Add microchip,sam9x60-pmecc to DT bindings documentation.
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com >
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com >
Acked-by: Rob Herring <robh@kernel.org >
Link: https://lore.kernel.org/r/1578673089-3484-9-git-send-email-claudiu.beznea@microchip.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2020-01-14 15:06:57 +01:00
Claudiu Beznea
00b9a43be0
dt-bindings: atmel-matrix: add microchip,sam9x60-matrix
...
Add microchip,sam9x60-matrix to DT bindings documentation.
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com >
Acked-by: Rob Herring <robh@kernel.org >
Link: https://lore.kernel.org/r/1578673089-3484-8-git-send-email-claudiu.beznea@microchip.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2020-01-14 15:06:56 +01:00
Claudiu Beznea
7c7acbc34d
dt-bindings: at91-sama5d2_adc: add microchip,sam9x60-adc
...
Add microchip,sam9x60-adc to DT bindings documentation.
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com >
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com >
Acked-by: Rob Herring <robh@kernel.org >
Link: https://lore.kernel.org/r/1578673089-3484-7-git-send-email-claudiu.beznea@microchip.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2020-01-14 15:06:56 +01:00
Claudiu Beznea
08c2da3da2
dt-bindings: atmel-isi: add microchip,sam9x60-isi
...
Add microchip,sam9x60-isi to DT bindings documentation.
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com >
Acked-by: Rob Herring <robh@kernel.org >
Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl >
Link: https://lore.kernel.org/r/1578673089-3484-6-git-send-email-claudiu.beznea@microchip.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2020-01-14 15:06:30 +01:00
Rui Feng
4d6168314d
misc: rtsx: Fix impossible condition
...
A u8 can only go up to 255, condition n > 396 is
impossible, so change u8 to u16.
Signed-off-by: Rui Feng <rui_feng@realsil.com.cn >
Link: https://lore.kernel.org/r/1574214006-13540-1-git-send-email-rui_feng@realsil.com.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:06:07 +01:00
Chuhong Yuan
efb5bea6b8
misc: isl29020: add missed pm_runtime_disable
...
The driver forgets to call pm_runtime_disable in remove.
Add the missed call to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com >
Link: https://lore.kernel.org/r/20191118080931.30749-1-hslester96@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:06:07 +01:00
Hongbo Yao
8edf4cd193
misc: genwqe: fix compile warnings
...
Using the following command will get compile warnings:
make W=1 drivers/misc/genwqe/card_ddcb.o ARCH=x86_64
drivers/misc/genwqe/card_ddcb.c: In function setup_ddcb_queue:
drivers/misc/genwqe/card_ddcb.c:1024:6: warning: variable rc set but not
used [-Wunused-but-set-variable]
drivers/misc/genwqe/card_ddcb.c: In function genwqe_card_thread:
drivers/misc/genwqe/card_ddcb.c:1190:23: warning: variable rc set but
not used [-Wunused-but-set-variable]
Reported-by: Hulk Robot <hulkci@huawei.com >
Signed-off-by: Hongbo Yao <yaohongbo@huawei.com >
Link: https://lore.kernel.org/r/20191205111655.170382-1-yaohongbo@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:06:06 +01:00
Ioana Ciornei
cff081ea9d
bus: fsl-mc: properly empty-initialize structure
...
Use the proper form of the empty initializer when working with
structures that contain an array. Otherwise, older gcc versions (eg gcc
4.9) will complain about this.
Fixes: 1ac210d128 ("bus: fsl-mc: add the fsl_mc_get_endpoint function")
Reported-by: kbuild test robot <lkp@intel.com >
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com >
Acked-by: Laurentiu Tudor <laurentiu.tudor@nxp.com >
Link: https://lore.kernel.org/r/20191204142950.30206-1-ioana.ciornei@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:06:06 +01:00
Tianlin Li
c576eddf1c
drivers/misc: sram-exec: have the callers of set_memory_*() check the return value
...
Right now several architectures allow their set_memory_*() family of
functions to fail, but callers may not be checking the return values.
If set_memory_*() returns with an error, call-site assumptions may be
infact wrong to assume that it would either succeed or not succeed at
all. Ideally, the failure of set_memory_*() should be passed up the call
stack, and callers should examine the failure and deal with it.
Need to fix the callers and add the __must_check attribute. They also
may not provide any level of atomicity, in the sense that the memory
protections may be left incomplete on failure. This issue likely has a
few steps on effects architectures:
1) Have all callers of set_memory_*() helpers check the return value.
2) Add __must_check to all set_memory_*() helpers so that new uses do
not ignore the return value.
3) Add atomicity to the calls so that the memory protections aren't
left in a partial state.
This series is part of step 1. Make sram driver check the return value
of set_memory_*().
Signed-off-by: Tianlin Li <tli@digitalocean.com >
Reviewed-by: Kees Cook <keescook@chromium.org >
Link: https://lore.kernel.org/r/20191217194528.16461-1-tli@digitalocean.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 15:06:06 +01:00
Michael Straube
cdb9c044f9
staging: rtl8188eu: cleanup whitespace in rtl8188e_dm.c
...
Replace tabs with spaces and/or remove spaces to use typical kernel
horizontal whitespace.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20200114134422.13598-5-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 14:59:47 +01:00
Michael Straube
8c26f783d7
staging: rtl8188eu: remove unnecessary parentheses in rtl8188e_dm.c
...
Remove unnecessary parentheses reported by checkpatch.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20200114134422.13598-4-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 14:59:47 +01:00
Michael Straube
c085fed4cb
staging: rtl8188eu: cleanup long lines in rtl8188e_dm.c
...
Cleanup lines over 80 characters in rtl8188e_dm.c by adding
appropriate line breaks.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20200114134422.13598-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 14:59:47 +01:00
Michael Straube
cdc7fa3232
staging: rtl8188eu: convert rtw_hal_antdiv_before_linked() to bool
...
Function rtw_hal_antdiv_before_linked() returns boolean values, so
change the return type from u8 to bool.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20200114134422.13598-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 14:59:47 +01:00
Michael Straube
c0a6bf0f1a
staging: rtl8188eu: refactor rtw_hal_antdiv_before_linked()
...
Refactor rtw_hal_antdiv_before_linked() to clear checkpatch warnings.
WARNING: line over 80 characters
WARNING: else is not generally useful after a break or return
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20200114134422.13598-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 14:59:47 +01:00
Michael Straube
98ab51df76
staging: rtl8723bs: remove ODM_GetRightChnlPlaceforIQK()
...
Function ODM_GetRightChnlPlaceforIQK() returns non-zero values only
for channels > 14. According to the TODO code valid only for 5 GHz
should be removed.
- find and remove remaining code valid only for 5 GHz. Most of the
obvious ones have been removed, but things like channel > 14 still
exist.
Remove ODM_GetRightChnlPlaceforIQK() and replace the uses of the
return value with zero.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20200110210456.13178-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 14:56:37 +01:00
Pragat Pandya
d85cad420a
staging: exfat: Fix alignment warnings
...
Fix checkpatch warning "Alignment should match open parenthesis".
Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com >
Link: https://lore.kernel.org/r/20200111142233.11354-1-pragat.pandya@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 14:56:36 +01:00
Michael Straube
f3c69559b5
staging: rtl8188eu: remove unused parameters from rtw_check_network_type
...
Parameters 'ratelen' and 'channel' of function rtw_check_network_type are
unused, remove them. Reduces object file size by 62 bytes.
text data bss dec hex filename
398525 12896 4688 416109 6596d drivers/staging/rtl8188eu/r8188eu.o
398463 12896 4688 416047 6592f drivers/staging/rtl8188eu/r8188eu.o
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20200113212939.9738-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-14 14:56:36 +01:00
Rocky Liao
5e6d8401ad
Bluetooth: hci_qca: Add qca_power_on() API to support both wcn399x and Rome power up
...
This patch adds a unified API qca_power_on() to support both wcn399x and
Rome power on. For wcn399x it calls the qca_wcn3990_init() to init the
regulators, and for Rome it pulls up the bt_en GPIO to power up the btsoc.
It also moves all the power up operation from hdev->open() to
hdev->setup().
Signed-off-by: Rocky Liao <rjliao@codeaurora.org >
Reviewed-by: Matthias Kaehlcke <mka@chromium.org >
Signed-off-by: Marcel Holtmann <marcel@holtmann.org >
2020-01-14 14:54:03 +01:00