Files
linux/kernel
Tetsuo Handa 016d370ba6 CRED: Fix BUG() upon security_cred_alloc_blank() failure
commit 2edeaa34a6 upstream.

In cred_alloc_blank() since 2.6.32, abort_creds(new) is called with
new->security == NULL and new->magic == 0 when security_cred_alloc_blank()
returns an error.  As a result, BUG() will be triggered if SELinux is enabled
or CONFIG_DEBUG_CREDENTIALS=y.

If CONFIG_DEBUG_CREDENTIALS=y, BUG() is called from __invalid_creds() because
cred->magic == 0.  Failing that, BUG() is called from selinux_cred_free()
because selinux_cred_free() is not expecting cred->security == NULL.  This does
not affect smack_cred_free(), tomoyo_cred_free() or apparmor_cred_free().

Fix these bugs by

(1) Set new->magic before calling security_cred_alloc_blank().

(2) Handle null cred->security in creds_are_invalid() and selinux_cred_free().

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-02 09:46:39 -05:00
..
2010-08-13 13:19:50 -07:00
2009-12-18 14:03:52 -08:00
2009-06-24 00:02:38 -04:00
2009-09-18 09:48:52 -07:00
2008-10-16 11:21:30 -07:00
2011-02-17 15:37:19 -08:00
2009-08-29 14:10:07 +02:00
2008-07-28 14:37:38 +02:00
2009-09-19 13:13:17 -07:00
2009-05-15 07:56:24 -05:00
2011-02-17 15:37:19 -08:00
2009-07-24 10:53:29 +02:00
2010-07-05 11:10:31 -07:00
2009-01-14 18:09:02 +01:00
2009-06-18 13:03:56 -07:00
2009-10-29 08:56:20 +10:30
2008-09-02 19:21:40 -07:00
2010-05-26 14:29:18 -07:00
2009-10-07 08:11:20 +02:00
2009-09-23 07:39:41 -07:00
2011-02-17 15:37:30 -08:00
2008-02-06 10:41:02 -08:00
2011-02-17 15:37:19 -08:00
2009-07-12 14:03:27 -07:00
2009-09-23 18:13:10 -07:00
2009-06-18 13:03:55 -07:00