Wang YanQing 884e961674 ubi: Fix return value overwrite issue in try_write_vid_and_data() ...

commit 31a149d5c1 upstream.

The commit 2d78aee426 ("UBI: simplify LEB write and atomic LEB change code")
adds helper function, try_write_vid_and_data(), to simplify the code, but this
helper function has bug, it will return 0 (success) when ubi_io_write_vid_hdr()
or the ubi_io_write_data() return error number (-EIO, etc), because the return
value of ubi_wl_put_peb() will overwrite the original return value.

This issue will cause unexpected data loss issue, because the caller of this
function and UBIFS willn't know the data is lost.

Fixes: 2d78aee426 ("UBI: simplify LEB write and atomic LEB change code")
Cc: stable@vger.kernel.org
Signed-off-by: Wang YanQing <udknight@gmail.com>
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2023-05-11 23:03:05 +09:00

..

chips

mtd: cfi_cmdset_0002: Rename chip_ready variables

2022-04-28 10:17:22 +02:00

devices

mtd: add ECC error accounting for each read request

2022-09-21 10:38:09 +02:00

hyperbus

mtd: hyperbus: rpc-if: Fix RPM imbalance in probe error path

2022-06-24 20:47:36 +02:00

lpddr

mtd: lpddr2_nvm: Fix possible null-ptr-deref

2022-12-31 13:32:12 +01:00

maps

mtd: maps: pxa2xx-flash: fix memory leak in probe

2022-12-31 13:32:15 +01:00

nand

mtd: rawnand: stm32_fmc2: use timings.mode instead of checking tRC_min

2023-04-20 12:35:07 +02:00

parsers

mtd: parsers: scpart: fix __udivdi3 undefined on mips

2023-01-18 11:58:24 +01:00

spi-nor

mtd: spi-nor: fix memory leak when using debugfs_lookup()

2023-04-26 14:28:37 +02:00

tests

treewide: use get_random_bytes() when possible

2022-10-11 17:42:58 -06:00

ubi

ubi: Fix return value overwrite issue in try_write_vid_and_data()

2023-05-11 23:03:05 +09:00

ftl.c

mtd: ftl: use container_of() rather than cast

2022-09-19 18:14:53 +02:00

inftlcore.c

mtd: always initialize 'stats' in struct mtd_oob_ops

2022-09-21 10:38:07 +02:00

inftlmount.c

mtd: inftl: remove unnecessary oom message

2021-06-11 20:44:21 +02:00

Kconfig

mtdblock: Add comment about UBI block devices

2021-08-06 22:05:13 +02:00

Makefile

mtd: Support kmsg dumper based on pstore/blk

2020-05-31 19:49:01 -07:00

mtd_blkdevs.c

block: remove blk_cleanup_disk

2022-06-28 06:33:15 -06:00

mtdblock_ro.c

mtdblock: Warn if added for a NAND device

2021-08-17 18:41:59 +02:00

mtdblock.c

mtdblock: tolerate corrected bit-flips

2023-04-20 12:35:06 +02:00

mtdchar.c

mtdchar: add MEMREAD ioctl

2022-09-21 10:38:11 +02:00

mtdconcat.c

mtd: fix repeated word in comment

2022-09-20 10:40:30 +02:00

mtdcore.c

mtd: core: Fix refcount error in del_mtd_device()

2022-12-31 13:32:15 +01:00

mtdcore.h

mtd: Provide fs_context-aware mount_mtd() replacement

2019-09-05 14:34:23 -04:00

mtdoops.c

mtd: mtdoops: Add a timestamp to the mtdoops header.

2022-04-26 09:27:12 +02:00

mtdpart.c

mtd: mtdpart: Don't create platform device that'll never probe

2023-03-10 09:33:38 +01:00

mtdpstore.c

mtd: Fix a typo in a comment

2022-09-19 18:14:53 +02:00

mtdsuper.c

mm: don't include <linux/blkdev.h> in <linux/backing-dev.h>

2021-10-18 06:17:01 -06:00

mtdswap.c

mtd: always initialize 'stats' in struct mtd_oob_ops

2022-09-21 10:38:07 +02:00

nftlcore.c

mtd: always initialize 'stats' in struct mtd_oob_ops

2022-09-21 10:38:07 +02:00

nftlmount.c

mtd: nftl: remove unnecessary oom message

2021-06-11 20:43:26 +02:00

rfd_ftl.c

mtd/rfd_ftl: don't cast away the type when calling add_mtd_blktrans_dev

2021-08-23 10:01:06 +02:00

sm_ftl.c

mtd: always initialize 'stats' in struct mtd_oob_ops

2022-09-21 10:38:07 +02:00

sm_ftl.h

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500

2019-06-19 17:09:55 +02:00

ssfdc.c

mtd: always initialize 'stats' in struct mtd_oob_ops

2022-09-21 10:38:07 +02:00