Files
linux/drivers
Jann Horn 742f306229 tty: Fix ->pgrp locking in tiocspgrp()
commit 54ffccbf05 upstream.

tiocspgrp() takes two tty_struct pointers: One to the tty that userspace
passed to ioctl() (`tty`) and one to the TTY being changed (`real_tty`).
These pointers are different when ioctl() is called with a master fd.

To properly lock real_tty->pgrp, we must take real_tty->ctrl_lock.

This bug makes it possible for racing ioctl(TIOCSPGRP, ...) calls on
both sides of a PTY pair to corrupt the refcount of `struct pid`,
leading to use-after-free errors.

Fixes: 47f86834bb ("redo locking of tty->pgrp")
CC: stable@kernel.org
Signed-off-by: Jann Horn <jannh@google.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-12-11 13:37:59 +01:00
..
2020-11-22 09:58:15 +01:00
2020-11-10 10:23:51 +01:00
2020-11-24 13:02:52 +01:00
2020-10-29 09:05:41 +01:00
2020-11-10 10:23:53 +01:00
2020-02-28 15:42:33 +01:00