Files
linux/crypto
Lukas Wunner f02f0218be crypto: ecdsa - Harden against integer overflows in DIV_ROUND_UP()
commit b16510a530d1e6ab9683f04f8fb34f2e0f538275 upstream.

Herbert notes that DIV_ROUND_UP() may overflow unnecessarily if an ecdsa
implementation's ->key_size() callback returns an unusually large value.
Herbert instead suggests (for a division by 8):

  X / 8 + !!(X & 7)

Based on this formula, introduce a generic DIV_ROUND_UP_POW2() macro and
use it in lieu of DIV_ROUND_UP() for ->key_size() return values.

Additionally, use the macro in ecc_digits_from_bytes(), whose "nbytes"
parameter is a ->key_size() return value in some instances, or a
user-specified ASN.1 length in the case of ecdsa_get_signature_rs().

Link: https://lore.kernel.org/r/Z3iElsILmoSu6FuC@gondor.apana.org.au/
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-07-17 18:35:22 +02:00
..
2023-06-23 16:15:36 +08:00
2022-03-03 10:49:20 +12:00
2023-05-24 18:12:33 +08:00
2021-03-26 19:55:55 +11:00
2023-06-16 20:30:35 +08:00
2023-06-27 15:40:24 +08:00
2020-02-28 08:43:21 +08:00
2023-02-14 13:39:33 +08:00
2022-12-02 18:12:40 +08:00
2022-04-08 16:12:46 +08:00
2022-12-02 18:12:40 +08:00
2022-06-10 16:40:16 +08:00
2024-10-04 16:28:49 +02:00
2021-11-08 16:55:21 -08:00