Chandan Rajendra
38620054ea
ext4: fix crash when a directory's i_size is too small
...
commit 9d5afec6b8 upstream.
On a ppc64 machine, when mounting a fuzzed ext2 image (generated by
fsfuzzer) the following call trace is seen,
VFS: brelse: Trying to free free buffer
WARNING: CPU: 1 PID: 6913 at /root/repos/linux/fs/buffer.c:1165 .__brelse.part.6+0x24/0x40
.__brelse.part.6+0x20/0x40 (unreliable)
.ext4_find_entry+0x384/0x4f0
.ext4_lookup+0x84/0x250
.lookup_slow+0xdc/0x230
.walk_component+0x268/0x400
.path_lookupat+0xec/0x2d0
.filename_lookup+0x9c/0x1d0
.vfs_statx+0x98/0x140
.SyS_newfstatat+0x48/0x80
system_call+0x58/0x6c
This happens because the directory that ext4_find_entry() looks up has
inode->i_size that is less than the block size of the filesystem. This
causes 'nblocks' to have a value of zero. ext4_bread_batch() ends up not
reading any of the directory file's blocks. This renders the entries in
bh_use[] array to continue to have garbage data. buffer_uptodate() on
bh_use[0] can then return a zero value upon which brelse() function is
invoked.
This commit fixes the bug by returning -ENOENT when the directory file
has no associated blocks.
Reported-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com >
Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-12-20 10:10:22 +01:00
..
2017-11-30 08:40:49 +00:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-12-14 09:53:15 +01:00
2017-12-20 10:10:17 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-12-14 09:52:54 +01:00
2017-11-02 11:10:55 +01:00
2017-12-20 10:10:19 +01:00
2017-12-20 10:10:17 +01:00
2017-11-24 08:37:05 +01:00
2017-06-12 13:20:20 +02:00
2017-11-02 11:10:55 +01:00
2017-11-30 08:40:44 +00:00
2017-07-15 12:00:42 -07:00
2017-08-24 13:23:03 -07:00
2017-11-02 11:10:55 +01:00
2017-11-30 08:40:45 +00:00
2017-07-11 06:09:21 -04:00
2017-11-02 11:10:55 +01:00
2017-09-07 11:59:42 -07:00
2017-03-03 11:38:56 -08:00
2017-11-02 11:10:55 +01:00
2017-12-20 10:10:22 +01:00
2017-12-14 09:53:14 +01:00
2017-12-05 11:26:29 +01:00
2017-11-02 11:10:55 +01:00
2017-10-25 16:34:27 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-03 07:39:19 -07:00
2017-11-30 08:40:45 +00:00
2017-07-07 19:38:17 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-09-07 11:59:42 -07:00
2017-12-05 11:26:30 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-12-20 10:10:20 +01:00
2017-12-20 10:10:18 +01:00
2017-11-30 08:40:44 +00:00
2017-11-02 11:10:55 +01:00
2017-11-30 08:40:47 +00:00
2017-11-02 11:10:55 +01:00
2017-11-24 08:37:04 +01:00
2017-11-02 11:10:55 +01:00
2016-12-24 11:46:01 -08:00
2017-11-02 11:10:55 +01:00
2017-12-20 10:10:18 +01:00
2017-11-03 07:39:19 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-09-06 17:27:26 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-04-08 17:33:32 +02:00
2017-11-02 11:10:55 +01:00
2017-07-06 03:31:46 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-12-14 09:53:09 +01:00
2017-09-14 19:29:55 -07:00
2016-12-24 11:46:01 -08:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-09-04 19:05:15 -04:00
2017-09-14 18:13:32 -07:00
2017-09-14 18:13:32 -07:00
2017-11-02 11:10:55 +01:00
2017-10-13 16:18:33 -07:00
2017-10-03 17:54:25 -07:00
2017-10-13 16:18:33 -07:00
2017-11-30 08:40:45 +00:00
2017-11-02 11:10:55 +01:00
2017-02-01 09:13:51 +01:00
2017-11-02 11:10:55 +01:00
2017-04-17 12:52:27 -04:00
2017-11-02 11:10:55 +01:00
2017-11-30 08:40:53 +00:00
2017-07-15 12:00:42 -07:00
2016-12-24 11:46:01 -08:00
2017-10-18 14:51:50 -04:00
2017-11-02 11:10:55 +01:00
2017-07-03 21:13:25 -07:00
2017-09-08 18:26:49 -07:00
2017-12-20 10:10:22 +01:00
2017-12-17 15:07:59 +01:00
2017-11-02 11:10:55 +01:00
2017-08-28 00:50:23 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-03-02 08:42:35 +01:00
2017-07-12 16:26:05 -07:00
2017-09-13 09:11:44 -07:00
2017-09-13 09:11:44 -07:00
2017-11-02 11:10:55 +01:00
2017-10-16 12:11:56 -07:00
2017-07-12 16:26:00 -07:00
2017-07-06 07:02:29 -04:00
2017-07-21 13:57:31 -04:00
2017-11-02 11:10:55 +01:00
2017-06-22 11:44:55 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-12-05 11:26:29 +01:00
2017-10-17 02:22:07 -04:00
2017-11-02 11:10:55 +01:00
2017-09-05 12:53:12 +02:00
2017-12-14 09:53:08 +01:00
2017-05-23 08:41:17 -05:00
2017-02-04 00:01:06 +13:00
2017-03-02 08:42:31 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-09-04 19:05:15 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-03 17:54:25 -07:00
2017-11-02 11:10:55 +01:00
2017-10-04 18:03:15 +11:00