shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-07 11:26:02 +09:00
Code Issues Packages Projects Releases Wiki Activity
Files
1047d4a5dfdba812fe9db2ebe4cf9396284c7b83
linux/fs
History
Jaegeuk Kim 21061b7d0f FROMLIST: f2fs: remove i_xattr_sem to avoid deadlock and fix the original issue 
This reverts commit 27161f13e3 "f2fs: avoid race in between read xattr & write xattr".

That introduced a deadlock case:

Thread #1:

[122554.641906][   T92]  f2fs_getxattr+0xd4/0x5fc
    -> waiting for f2fs_down_read(&F2FS_I(inode)->i_xattr_sem);

[122554.641927][   T92]  __f2fs_get_acl+0x50/0x284
[122554.641948][   T92]  f2fs_init_acl+0x84/0x54c
[122554.641969][   T92]  f2fs_init_inode_metadata+0x460/0x5f0
[122554.641990][   T92]  f2fs_add_inline_entry+0x11c/0x350
    -> Locked dir->inode_page by f2fs_get_node_page()

[122554.642009][   T92]  f2fs_do_add_link+0x100/0x1e4
[122554.642025][   T92]  f2fs_create+0xf4/0x22c
[122554.642047][   T92]  vfs_create+0x130/0x1f4

Thread #2:

[123996.386358][   T92]  __get_node_page+0x8c/0x504
    -> waiting for dir->inode_page lock

[123996.386383][   T92]  read_all_xattrs+0x11c/0x1f4
[123996.386405][   T92]  __f2fs_setxattr+0xcc/0x528
[123996.386424][   T92]  f2fs_setxattr+0x158/0x1f4
    -> f2fs_down_write(&F2FS_I(inode)->i_xattr_sem);

[123996.386443][   T92]  __f2fs_set_acl+0x328/0x430
[123996.386618][   T92]  f2fs_set_acl+0x38/0x50
[123996.386642][   T92]  posix_acl_chmod+0xc8/0x1c8
[123996.386669][   T92]  f2fs_setattr+0x5e0/0x6bc
[123996.386689][   T92]  notify_change+0x4d8/0x580
[123996.386717][   T92]  chmod_common+0xd8/0x184
[123996.386748][   T92]  do_fchmodat+0x60/0x124
[123996.386766][   T92]  __arm64_sys_fchmodat+0x28/0x3c

Let's take a look at the original issue back.

Thread A:                                       Thread B:
-f2fs_getxattr
   -lookup_all_xattrs
      -xnid = F2FS_I(inode)->i_xattr_nid;
                                                -f2fs_setxattr
                                                    -__f2fs_setxattr
                                                        -write_all_xattrs
                                                            -truncate_xattr_node
                                                                  ...  ...
                                                -write_checkpoint
                                                                  ...  ...
                                                -alloc_nid   <- nid reuse
          -get_node_page
              -f2fs_bug_on  <- nid != node_footer->nid

I think we don't need to truncate xattr pages eagerly which introduces lots of
data races without big benefits.

Bug: 280545073
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/linux-f2fs-devel/20230613233940.3643362-1-jaegeuk@kernel.org/T/#u
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Change-Id: Ifdbaf7defa50b479d82d2c945aa9d48e2e2317ed
2023-06-23 09:08:28 +00:00
..
9p
use less confusing names for iov_iter direction initializers
2023-02-09 11:28:04 +01:00
adfs
fs: Convert block_read_full_page() to block_read_full_folio()
2022-05-09 16:21:44 -04:00
affs
affs: initialize fsdata in affs_truncate()
2023-02-01 08:34:08 +01:00
afs
use less confusing names for iov_iter direction initializers
2023-02-09 11:28:04 +01:00
autofs
autofs: remove unused ino field inode
2022-07-17 17:31:42 -07:00
befs
befs: Convert befs_symlink_read_folio() to use a folio
2022-08-02 12:34:03 -04:00
bfs
fs: Convert block_read_full_page() to block_read_full_folio()
2022-05-09 16:21:44 -04:00
btrfs
Merge 55fba69fbf ("rust: kernel: Mark rust_fmt_argument as extern "C"") into android14-6.1
2023-05-09 03:32:41 +00:00
cachefiles
cachefiles: use vfs_tmpfile_open() helper
2022-09-24 07:00:00 +02:00
ceph
ceph: update the time stamps and try to drop the suid/sgid
2023-03-10 09:34:25 +01:00
cifs
cifs: fix negotiate context parsing
2023-04-20 12:35:14 +02:00
coda
coda: Avoid partial allocation of sig_inputArgs
2023-03-10 09:33:52 +01:00
configfs
configfs: fix possible memory leak in configfs_create_dir()
2022-12-31 13:32:22 +01:00
cramfs
UPSTREAM: mm: replace vma->vm_flags direct modifications with modifier calls
2023-06-07 14:24:57 +00:00
crypto
Merge remote-tracking branch 'aosp/upstream-f2fs-stable-linux-6.1.y' into android14-6.1
2023-05-04 16:50:47 -07:00
debugfs
debugfs: fix error when writing negative value to atomic_t debugfs file
2022-12-31 13:31:58 +01:00
devpts
…
dlm
fs: dlm: fix race setting stop tx flag
2023-03-17 08:50:19 +01:00
ecryptfs
Merge tag 'pull-path' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2022-10-06 17:31:02 -07:00
efivarfs
efi: efivars: Fix variable writes without query_variable_store()
2022-10-21 11:09:40 +02:00
efs
efs: Convert efs symlinks to read_folio
2022-05-09 16:21:45 -04:00
erofs
UPSTREAM: mm: replace vma->vm_flags direct modifications with modifier calls
2023-06-07 14:24:57 +00:00
exfat
exfat: fix inode->i_blocks for non-512 byte sector size device
2023-03-10 09:34:08 +01:00
exportfs
Change calling conventions for filldir_t
2022-08-17 17:25:04 -04:00
ext2
ext2: unbugger ext2_empty_dir()
2023-01-07 11:11:40 +01:00
ext4
UPSTREAM: mm: replace vma->vm_flags direct modifications with modifier calls
2023-06-07 14:24:57 +00:00
f2fs
FROMLIST: f2fs: remove i_xattr_sem to avoid deadlock and fix the original issue
2023-06-23 09:08:28 +00:00
fat
treewide: use get_random_u32() when possible
2022-10-11 17:42:58 -06:00
freevxfs
freevxfs: Convert vxfs_immed_read_folio() to use a folio
2022-08-02 12:34:03 -04:00
fscache
fscache: Use clear_and_wake_up_bit() in fscache_create_volume_work()
2023-02-22 12:59:43 +01:00
fuse
ANDROID: fuse-bpf: Move FUSE_RELEASE to correct place
2023-06-21 18:36:19 +00:00
gfs2
gfs2: Improve gfs2_make_fs_rw error handling
2023-03-10 09:33:59 +01:00
hfs
hfs: fix missing hfs_bnode_get() in __hfs_bnode_create
2023-03-10 09:34:07 +01:00
hfsplus
fs: hfsplus: fix UAF issue in hfsplus_put_super
2023-03-10 09:34:07 +01:00
hostfs
hostfs: move from strlcpy with unused retval to strscpy
2022-09-19 22:46:25 +02:00
hpfs
hpfs: Convert symlinks to read_folio
2022-05-09 16:21:45 -04:00
hugetlbfs
UPSTREAM: mm: replace vma->vm_flags direct modifications with modifier calls
2023-06-07 14:24:57 +00:00
incfs
ANDROID: Remove all but top-level OWNERS
2023-06-15 09:54:33 +01:00
iomap
iomap: add a tracepoint for mappings returned by map_blocks
2022-10-02 11:42:19 -07:00
isofs
Merge f8142cf94d ("hugetlb: make hugetlb depends on SYSFS or SYSCTL") into android-mainline
2022-10-20 11:56:25 +02:00
jbd2
jbd2: fix data missing when reusing bh which is ready to be checkpointed
2023-03-10 09:34:20 +01:00
jffs2
jffs2: correct logic when creating a hole in jffs2_write_begin
2023-03-22 13:33:53 +01:00
jfs
fs/jfs: fix shift exponent db_agl2size negative
2023-03-11 13:55:16 +01:00
kernfs
kernfs: Fix spurious lockdep warning in kernfs_find_and_get_node_by_id()
2022-11-10 19:03:42 +01:00
ksmbd
ksmbd: avoid out of bounds access in decode_preauth_ctxt()
2023-04-20 12:35:12 +02:00
lockd
lockd: set file_lock start and end when decoding nlm4 testargs
2023-03-30 12:49:23 +02:00
minix
vfs: open inside ->tmpfile()
2022-09-24 07:00:00 +02:00
netfs
use less confusing names for iov_iter direction initializers
2023-02-09 11:28:04 +01:00
nfs
NFSv4: Fix hangs when recovering open state after a server reboot
2023-04-06 12:10:54 +02:00
nfs_common
…
nfsd
NFSD: callback request does not use correct credential for AUTH_SYS
2023-04-13 16:55:23 +02:00
nilfs2
nilfs2: initialize unused bytes in segment summary blocks
2023-04-26 14:28:39 +02:00
nls
…
notify
ANDROID: fuse: Support errors from fuse daemon in canonical path
2023-04-12 02:08:29 +00:00
ntfs
Merge tag 'mm-nonmm-stable-2022-10-11' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-10-12 11:00:22 -07:00
ntfs3
ANDROID: Revert "mm: remove cleancache"
2023-04-26 17:01:50 +00:00
ocfs2
ANDROID: Revert "mm: remove cleancache"
2023-04-26 17:01:50 +00:00
omfs
fs: Convert block_read_full_page() to block_read_full_folio()
2022-05-09 16:21:44 -04:00
openpromfs
…
orangefs
UPSTREAM: mm: replace vma->vm_flags direct modifications with modifier calls
2023-06-07 14:24:57 +00:00
overlayfs
BACKPORT: FROMLIST: ovl: get_acl: Fix null pointer dereference at realinode in rcu-walk mode
2023-06-07 00:40:32 +00:00
proc
UPSTREAM: mm: replace vma->vm_flags direct modifications with modifier calls
2023-06-07 14:24:57 +00:00
pstore
FROMGIT: pstore: Revert pmsg_lock back to a normal mutex
2023-03-09 21:58:51 +00:00
qnx4
fs: Convert block_read_full_page() to block_read_full_folio()
2022-05-09 16:21:44 -04:00
qnx6
fs/qnx6: delete unnecessary checks before brelse()
2022-09-11 21:55:07 -07:00
quota
ext4: fix bug_on in __es_tree_search caused by bad quota inode
2023-01-07 11:11:59 +01:00
ramfs
Merge tag 'pull-tmpfile' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2022-10-10 19:45:17 -07:00
reiserfs
reiserfs: Add missing calls to reiserfs_security_free()
2022-12-31 13:33:10 +01:00
romfs
romfs: Convert romfs to read_folio
2022-05-09 16:21:46 -04:00
smbfs_common
smb3: define missing create contexts
2022-10-05 01:55:27 -05:00
squashfs
revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"
2023-02-22 12:59:50 +01:00
sysfs
…
sysv
fs: sysv: Fix sysv_nblocks() returns wrong value
2022-12-31 13:32:00 +01:00
tracefs
tracefs: Only clobber mode/uid/gid on remount if asked
2022-09-08 17:10:54 -04:00
ubifs
ubifs: ubifs_releasepage: Remove ubifs_assert(0) to valid this process
2023-03-11 13:55:21 +01:00
udf
udf: Fix off-by-one error when discarding preallocation
2023-03-17 08:50:19 +01:00
ufs
ufs: replace ll_rw_block()
2022-09-11 20:26:07 -07:00
unicode
…
vboxsf
vboxsf: Convert vboxsf to read_folio
2022-05-09 16:21:46 -04:00
verity
Merge 6.1.23 into android14-6.1
2023-04-06 14:14:07 +00:00
xfs
UPSTREAM: xfs: verify buffer contents when we skip log replay
2023-06-19 13:21:31 +00:00
zonefs
zonefs: Always invalidate last cached page on append write
2023-04-06 12:10:52 +02:00
aio.c
UPSTREAM: mm: replace vma->vm_flags direct modifications with modifier calls
2023-06-07 14:24:57 +00:00
anon_inodes.c
dynamic_dname(): drop unused dentry argument
2022-08-20 11:34:04 -04:00
attr.c
attr: use consistent sgid stripping checks
2023-03-03 11:52:25 +01:00
bad_inode.c
vfs: open inside ->tmpfile()
2022-09-24 07:00:00 +02:00
binfmt_elf_fdpic.c
elfcore: Add a cprm parameter to elf_core_extra_{phdrs,data_size}
2023-01-18 11:58:12 +01:00
binfmt_elf_test.c
…
binfmt_elf.c
elfcore: Add a cprm parameter to elf_core_extra_{phdrs,data_size}
2023-01-18 11:58:12 +01:00
binfmt_flat.c
binfmt_flat: Remove shared library support
2022-04-22 10:57:18 -07:00
binfmt_misc.c
binfmt_misc: fix shift-out-of-bounds in check_special_flags
2022-12-31 13:32:57 +01:00
binfmt_script.c
…
buffer.c
fscrypt: support decrypting data from large folios
2023-02-27 19:45:05 -08:00
char_dev.c
chardev: fix error handling in cdev_device_add()
2022-12-31 13:32:41 +01:00
compat_binfmt_elf.c
…
coredump.c
coredump: Move dump_emit_page() to kill unused warning
2023-02-22 12:59:50 +01:00
d_path.c
d_path.c: typo fix...
2022-08-20 11:34:33 -04:00
dax.c
Merge branch 'for-6.0/dax' into libnvdimm-fixes
2022-09-24 18:14:12 -07:00
dcache.c
Merge tag 'pull-tmpfile' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2022-10-10 19:45:17 -07:00
direct-io.c
block: remove PSI accounting from the bio layer
2022-09-20 08:24:38 -06:00
drop_caches.c
…
eventfd.c
eventfd: provide a eventfd_signal_mask() helper
2023-01-04 11:28:48 +01:00
eventpoll.c
eventpoll: add EPOLL_URING_WAKE poll wakeup flag
2023-01-04 11:28:47 +01:00
exec.c
UPSTREAM: mm: replace vma->vm_flags direct modifications with modifier calls
2023-06-07 14:24:57 +00:00
fcntl.c
keep iocb_flags() result cached in struct file
2022-06-10 16:10:23 -04:00
fhandle.c
do_sys_name_to_handle(): constify path
2022-09-01 17:36:39 -04:00
file_table.c
locks: fix TOCTOU race when granting write lease
2022-08-16 10:59:54 -04:00
file.c
fs: prevent out-of-bounds array speculation when closing a file descriptor
2023-03-17 08:50:13 +01:00
filesystems.c
…
fs_context.c
…
fs_parser.c
ext4: journal_path mount options should follow links
2023-01-07 11:11:59 +01:00
fs_pin.c
…
fs_struct.c
…
fs_types.c
…
fs-writeback.c
writeback, cgroup: fix null-ptr-deref write in bdi_split_work_to_wbs
2023-04-26 14:28:39 +02:00
fsopen.c
uninline may_mount() and don't opencode it in fspick(2)/fsopen(2)
2022-05-19 23:25:10 -04:00
init.c
…
inode.c
attr: use consistent sgid stripping checks
2023-03-03 11:52:25 +01:00
internal.h
attr: use consistent sgid stripping checks
2023-03-03 11:52:25 +01:00
ioctl.c
…
Kconfig
Merge f8142cf94d ("hugetlb: make hugetlb depends on SYSFS or SYSCTL") into android-mainline
2022-10-20 11:56:25 +02:00
Kconfig.binfmt
Merge tag 'xtensa-20221010' of https://github.com/jcmvbkbc/linux-xtensa
2022-10-10 14:21:11 -07:00
kernel_read_file.c
fs/kernel_read_file: allow to read files up-to ssize_t
2022-06-16 19:58:21 -07:00
libfs.c
libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value
2022-12-31 13:31:58 +01:00
locks.c
filelocks: use mount idmapping for setlease permission check
2023-03-17 08:50:32 +01:00
Makefile
Merge 865dad2022 ("Merge tag 'kcfi-v6.1-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux") into android-mainline
2022-10-07 18:32:03 +02:00
mbcache.c
ext4: fix deadlock due to mbcache entry corruption
2023-01-07 11:12:02 +01:00
mount.h
switch try_to_unlazy_next() to __legitimize_mnt()
2022-07-05 16:18:21 -04:00
mpage.c
ANDROID: Revert "mm: remove cleancache"
2023-04-26 17:01:50 +00:00
namei.c
vfs: vfs_tmpfile: ensure O_EXCL flag is enforced
2022-11-19 02:22:11 -05:00
namespace.c
fs: drop peer group ids under namespace lock
2023-04-13 16:55:33 +02:00
no-block.c
…
nsfs.c
dynamic_dname(): drop unused dentry argument
2022-08-20 11:34:04 -04:00
open.c
ANDROID: Add filp_open_block() for zram
2023-04-21 20:05:56 +00:00
pipe.c
dynamic_dname(): drop unused dentry argument
2022-08-20 11:34:04 -04:00
pnode.c
pnode: terminate at peers of source
2023-01-04 11:29:01 +01:00
pnode.h
…
posix_acl.c
Merge tag 'mm-stable-2022-10-08' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-10-10 17:53:04 -07:00
proc_namespace.c
vfs: escape hash as well
2022-06-28 13:58:05 -04:00
read_write.c
use less confusing names for iov_iter direction initializers
2023-02-09 11:28:04 +01:00
readdir.c
Change calling conventions for filldir_t
2022-08-17 17:25:04 -04:00
remap_range.c
Merge tag 'mm-stable-2022-08-03' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-08-05 16:32:45 -07:00
select.c
FROMLIST: fs/select: mark do_select noinline_for_stack
2022-10-12 07:12:54 +00:00
seq_file.c
use less confusing names for iov_iter direction initializers
2023-02-09 11:28:04 +01:00
signalfd.c
…
splice.c
use less confusing names for iov_iter direction initializers
2023-02-09 11:28:04 +01:00
stack.c
…
stat.c
vfs: support STATX_DIOALIGN on block devices
2022-09-11 19:47:12 -05:00
statfs.c
…
super.c
fscrypt: destroy keyring after security_sb_delete()
2023-05-04 10:49:24 -07:00
sync.c
Merge f8a52af9d0 ("Merge tag 'i2c-for-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux") into android-mainline
2022-06-29 20:00:36 +02:00
sysctls.c
…
timerfd.c
…
userfaultfd.c
UPSTREAM: mm: replace vma->vm_flags direct modifications with modifier calls
2023-06-07 14:24:57 +00:00
utimes.c
…
xattr.c
fs: don't audit the capability check in simple_xattr_list()
2022-12-31 13:31:55 +01:00