shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-03-27 04:50:25 +09:00
Code Issues Packages Projects Releases Wiki Activity
Files
119dcafe36795a15ae53351cbbd6177aaf94ffef
linux/fs/xfs
History
Darrick J. Wong 4534162e09 xfs: don't over-report free space or inodes in statvfs 
[ Upstream commit 4b8d867ca6e2fc6d152f629fdaf027053b81765a ]

Emmanual Florac reports a strange occurrence when project quota limits
are enabled, free space is lower than the remaining quota, and someone
runs statvfs:

  # mkfs.xfs -f /dev/sda
  # mount /dev/sda /mnt -o prjquota
  # xfs_quota  -x -c 'limit -p bhard=2G 55' /mnt
  # mkdir /mnt/dir
  # xfs_io -c 'chproj 55' -c 'chattr +P' -c 'stat -vvvv' /mnt/dir
  # fallocate -l 19g /mnt/a
  # df /mnt /mnt/dir
  Filesystem      Size  Used Avail Use% Mounted on
  /dev/sda         20G   20G  345M  99% /mnt
  /dev/sda        2.0G     0  2.0G   0% /mnt

I think the bug here is that xfs_fill_statvfs_from_dquot unconditionally
assigns to f_bfree without checking that the filesystem has enough free
space to fill the remaining project quota.  However, this is a
longstanding behavior of xfs so it's unclear what to do here.

Cc: <stable@vger.kernel.org> # v2.6.18
Fixes: 932f2c3231 ("[XFS] statvfs component of directory/project quota support, code originally by Glen.")
Reported-by: Emmanuel Florac <eflorac@intellique.com>
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2025-02-27 04:10:44 -08:00
..
libxfs
xfs: Reduce unnecessary searches when searching for the best extents
2025-02-27 04:10:43 -08:00
scrub
xfs: attr forks require attr, not attr2
2024-12-27 13:58:45 +01:00
Kconfig
xfs: verify buffer, inode, and dquot items every tx commit
2024-12-27 13:58:44 +01:00
kmem.c
mm: introduce memalloc_retry_wait()
2022-01-15 16:30:29 +02:00
kmem.h
xfs: remove kmem_zone typedef
2021-10-22 16:00:31 -07:00
Makefile
xfs: move the realtime summary file scrubber to a separate source file
2023-08-10 07:48:09 -07:00
mrlock.h
…
xfs_acl.c
xfs: convert to ctime accessor functions
2023-07-24 10:30:06 +02:00
xfs_acl.h
fs: port ->set_acl() to pass mnt_idmap
2023-01-19 09:24:27 +01:00
xfs_aops.c
xfs: make xfs_bmapi_convert_delalloc() to allocate the target offset
2024-10-22 15:46:23 +02:00
xfs_aops.h
…
xfs_attr_inactive.c
xfs: make inode unlinked bucket recovery work with quotacheck
2023-09-12 10:31:07 -07:00
xfs_attr_item.c
xfs: enforce one namespace per attribute
2024-10-22 15:46:23 +02:00
xfs_attr_item.h
xfs: share xattr name and value buffers when logging xattr updates
2022-05-23 08:43:46 +10:00
xfs_attr_list.c
xfs: enforce one namespace per attribute
2024-10-22 15:46:23 +02:00
xfs_bio_io.c
fs/xfs: Use the enum req_op and blk_opf_t types
2022-07-14 12:14:33 -06:00
xfs_bmap_item.c
xfs: transfer recovered intent item ownership in ->iop_recover
2024-04-03 15:28:47 +02:00
xfs_bmap_item.h
xfs: rename _zone variables to _cache
2021-10-22 16:04:20 -07:00
xfs_bmap_util.c
xfs: Fix xfs_prepare_shift() range for RT
2024-12-27 13:58:45 +01:00
xfs_bmap_util.h
xfs: fix freeing speculative preallocations for preallocated files
2024-10-22 15:46:24 +02:00
xfs_buf_item_recover.c
xfs: update the pag for the last AG at recovery time
2025-02-27 04:10:43 -08:00
xfs_buf_item.c
xfs: verify buffer, inode, and dquot items every tx commit
2024-12-27 13:58:44 +01:00
xfs_buf_item.h
xfs: convert buffer log item flags to unsigned.
2022-04-21 10:46:40 +10:00
xfs_buf.c
xfs: force all buffers to be written during btree bulk load
2024-04-03 15:28:48 +02:00
xfs_buf.h
xfs: force all buffers to be written during btree bulk load
2024-04-03 15:28:48 +02:00
xfs_dahash_test.c
xfs: test the ascii case-insensitive hash
2023-04-11 19:05:05 -07:00
xfs_dahash_test.h
xfs: test dir/attr hash when loading module
2023-03-19 09:55:49 -07:00
xfs_dir2_readdir.c
xfs: rearrange the logic and remove the broken comment for xfs_dir2_isxx
2022-10-04 16:39:58 +11:00
xfs_discard.c
xfs: abort fstrim if kernel is suspending
2023-10-04 09:25:04 +11:00
xfs_discard.h
xfs: move log discard work to xfs_discard.c
2023-10-04 09:24:02 +11:00
xfs_dquot_item_recover.c
xfs: dquot recovery does not validate the recovered dquot
2024-02-16 19:10:46 +01:00
xfs_dquot_item.c
xfs: verify buffer, inode, and dquot items every tx commit
2024-12-27 13:58:44 +01:00
xfs_dquot_item.h
xfs: remove support for disabling quota accounting on a mounted file system
2021-08-06 11:05:36 -07:00
xfs_dquot.c
xfs: fix error returns from xfs_bmapi_write
2024-10-22 15:46:21 +02:00
xfs_dquot.h
xfs: remove warning counters from struct xfs_dquot_res
2022-05-11 17:12:09 +10:00
xfs_drain.c
xfs: minimize overhead of drain wakeups by using jump labels
2023-04-11 18:59:59 -07:00
xfs_drain.h
xfs: minimize overhead of drain wakeups by using jump labels
2023-04-11 18:59:59 -07:00
xfs_error.c
xfs: make kobj_type structures constant
2023-02-10 08:59:48 -08:00
xfs_error.h
xfs: allow setting full range of panic tags
2023-02-09 18:36:17 -08:00
xfs_export.c
xfs: fix reloading entire unlinked bucket lists
2023-09-24 18:12:13 -07:00
xfs_export.h
…
xfs_extent_busy.c
xfs: process free extents to busy list in FIFO order
2023-10-11 12:35:21 -07:00
xfs_extent_busy.h
xfs: reduce AGF hold times during fstrim operations
2023-10-04 09:24:52 +11:00
xfs_extfree_item.c
xfs: transfer recovered intent item ownership in ->iop_recover
2024-04-03 15:28:47 +02:00
xfs_extfree_item.h
xfs: refactor all the EFI/EFD log item sizeof logic
2022-10-31 08:58:20 -07:00
xfs_file.c
xfs: create a new helper to return a file's allocation unit
2024-12-27 13:58:44 +01:00
xfs_file.h
xfs: create a new helper to return a file's allocation unit
2024-12-27 13:58:44 +01:00
xfs_filestream.c
xfs: streamline xfs_filestream_pick_ag
2025-02-27 04:10:44 -08:00
xfs_filestream.h
xfs: pass perag to filestreams tracing
2023-02-13 09:14:56 +11:00
xfs_fsmap.c
xfs: use XFS_BUF_DADDR_NULL for daddrs in getfsmap code
2024-12-27 13:58:46 +01:00
xfs_fsmap.h
xfs: fix deadlock and streamline xfs_getfsmap performance
2020-10-07 08:40:29 -07:00
xfs_fsops.c
xfs: pass the exact range to initialize to xfs_initialize_perag
2025-02-27 04:10:43 -08:00
xfs_fsops.h
xfs: get rid of xfs_growfs_{data,log}_t
2021-02-03 09:18:50 -08:00
xfs_globals.c
xfs: allow setting full range of panic tags
2023-02-09 18:36:17 -08:00
xfs_health.c
xfs: replace XFS_FORCED_SHUTDOWN with xfs_is_shutdown
2021-08-19 10:07:13 -07:00
xfs_icache.c
xfs: don't free cowblocks from under dirty pagecache on unshare
2025-02-27 04:10:42 -08:00
xfs_icache.h
xfs: use per-mount cpumask to track nonempty percpu inodegc lists
2023-09-11 08:39:03 -07:00
xfs_icreate_item.c
xfs: fix potential log item leak
2022-05-04 11:45:11 +10:00
xfs_icreate_item.h
xfs: rename _zone variables to _cache
2021-10-22 16:04:20 -07:00
xfs_inode_item_recover.c
xfs: inode recovery does not validate the recovered inode
2024-02-16 19:10:45 +01:00
xfs_inode_item.c
xfs: verify buffer, inode, and dquot items every tx commit
2024-12-27 13:58:44 +01:00
xfs_inode_item.h
xfs: fix AGF vs inode cluster buffer deadlock
2023-06-05 04:08:27 +10:00
xfs_inode.c
xfs: Check for delayed allocations before setting extsize
2025-02-27 04:10:44 -08:00
xfs_inode.h
xfs: Check for delayed allocations before setting extsize
2025-02-27 04:10:44 -08:00
xfs_ioctl32.c
fs: port i_{g,u}id_into_vfs{g,u}id() to mnt_idmap
2023-01-19 09:24:29 +01:00
xfs_ioctl32.h
xfs: remove unused xfs_ioctl32.h declarations
2022-01-18 10:18:36 -08:00
xfs_ioctl.c
xfs: Check for delayed allocations before setting extsize
2025-02-27 04:10:44 -08:00
xfs_ioctl.h
fs: port ->fileattr_set() to pass mnt_idmap
2023-01-19 09:24:27 +01:00
xfs_iomap.c
xfs: Propagate errors from xfs_reflink_cancel_cow_range in xfs_dax_write_iomap_end
2025-02-17 09:40:31 +01:00
xfs_iomap.h
xfs: use iomap_valid method to detect stale cached iomaps
2022-11-29 09:09:17 +11:00
xfs_iops.c
xfs: declare xfs_file.c symbols in xfs_file.h
2024-12-27 13:58:44 +01:00
xfs_iops.h
xfs: declare xfs_file.c symbols in xfs_file.h
2024-12-27 13:58:44 +01:00
xfs_itable.c
xfs: fix reloading entire unlinked bucket lists
2023-09-24 18:12:13 -07:00
xfs_itable.h
fs: port i_{g,u}id_into_vfs{g,u}id() to mnt_idmap
2023-01-19 09:24:29 +01:00
xfs_iunlink_item.c
xfs: create traced helper to get extra perag references
2023-04-11 18:59:55 -07:00
xfs_iunlink_item.h
xfs: add in-memory iunlink log item
2022-07-14 11:47:42 +10:00
xfs_iwalk.c
xfs: create traced helper to get extra perag references
2023-04-11 18:59:55 -07:00
xfs_iwalk.h
xfs: Decouple XFS_IBULK flags from XFS_IWALK flags
2022-04-13 07:02:44 +00:00
xfs_linux.h
xfs: create scaffolding for creating debugfs entries
2023-08-10 07:48:07 -07:00
xfs_log_cil.c
xfs: Use try_cmpxchg() in xlog_cil_insert_pcp_aggregate()
2025-02-27 04:10:43 -08:00
xfs_log_priv.h
xfs: use xfs_defer_pending objects to recover intent items
2024-04-03 15:28:46 +02:00
xfs_log_recover.c
xfs: update the file system geometry after recoverying superblock buffers
2025-02-27 04:10:43 -08:00
xfs_log.c
xfs: use xfs_defer_pending objects to recover intent items
2024-04-03 15:28:46 +02:00
xfs_log.h
xfs: Remove empty declartion in header file
2025-02-27 04:10:43 -08:00
xfs_message.c
Merge branch 'guilt/xfs-unsigned-flags-5.18' into xfs-5.19-for-next
2022-04-21 16:45:03 +10:00
xfs_message.h
xfs: implement per-mount warnings for scrub and shrink usage
2022-05-27 10:31:34 +10:00
xfs_mount.c
xfs: pass the exact range to initialize to xfs_initialize_perag
2025-02-27 04:10:43 -08:00
xfs_mount.h
xfs: make inode unlinked bucket recovery work with quotacheck
2023-09-12 10:31:07 -07:00
xfs_mru_cache.c
xfs: rename _zone variables to _cache
2021-10-22 16:04:20 -07:00
xfs_mru_cache.h
…
xfs_notify_failure.c
xfs: correct calculation for agend and blockcount
2023-10-12 10:11:56 +05:30
xfs_ondisk.h
xfs: convert flex-array declarations in xfs attr shortform objects
2023-07-17 08:48:56 -07:00
xfs_pnfs.c
fs: port ->setattr() to pass mnt_idmap
2023-01-19 09:24:02 +01:00
xfs_pnfs.h
…
xfs_pwork.c
xfs: increase the default parallelism levels of pwork clients
2021-02-03 09:18:49 -08:00
xfs_pwork.h
xfs: increase the default parallelism levels of pwork clients
2021-02-03 09:18:49 -08:00
xfs_qm_bhv.c
xfs: don't over-report free space or inodes in statvfs
2025-02-27 04:10:44 -08:00
xfs_qm_syscalls.c
xfs: introduce xfs_inodegc_push()
2022-06-23 13:34:38 -07:00
xfs_qm.c
xfs: fix reloading entire unlinked bucket lists
2023-09-24 18:12:13 -07:00
xfs_qm.h
xfs: remove quota warning limit from struct xfs_quota_limits
2022-05-11 17:12:09 +10:00
xfs_quota.h
xfs: queue inactivation immediately when quota is nearing enforcement
2021-08-09 10:52:18 -07:00
xfs_quotaops.c
xfs: don't set quota warning values
2022-05-11 17:12:09 +10:00
xfs_refcount_item.c
xfs: transfer recovered intent item ownership in ->iop_recover
2024-04-03 15:28:47 +02:00
xfs_refcount_item.h
xfs: rename _zone variables to _cache
2021-10-22 16:04:20 -07:00
xfs_reflink.c
xfs: don't free cowblocks from under dirty pagecache on unshare
2025-02-27 04:10:42 -08:00
xfs_reflink.h
xfs: don't free cowblocks from under dirty pagecache on unshare
2025-02-27 04:10:42 -08:00
xfs_rmap_item.c
xfs: transfer recovered intent item ownership in ->iop_recover
2024-04-03 15:28:47 +02:00
xfs_rmap_item.h
xfs: rename _zone variables to _cache
2021-10-22 16:04:20 -07:00
xfs_rtalloc.c
xfs: reset rootdir extent size hint after growfsrt
2024-12-27 13:58:46 +01:00
xfs_rtalloc.h
xfs: move the xfs_rtbitmap.c declarations to xfs_rtbitmap.h
2024-04-03 15:28:46 +02:00
xfs_stats.c
xfs: replace unnecessary seq_printf with seq_puts
2022-09-19 06:48:14 +10:00
xfs_stats.h
xfs: periodically relog deferred intent items
2020-10-07 08:40:28 -07:00
xfs_super.c
xfs: report realtime block quota limits on realtime directories
2025-02-27 04:10:44 -08:00
xfs_super.h
xfs: create scaffolding for creating debugfs entries
2023-08-10 07:48:07 -07:00
xfs_symlink.c
xfs: use consistent uid/gid when grabbing dquots for inodes
2024-12-27 13:58:44 +01:00
xfs_symlink.h
fs: port inode_init_owner() to mnt_idmap
2023-01-19 09:24:28 +01:00
xfs_sysctl.c
xfs: simplify two-level sysctl registration for xfs_table
2023-04-13 11:49:35 -07:00
xfs_sysctl.h
xfs: Add larp debug option
2022-05-11 17:01:22 +10:00
xfs_sysfs.c
xfs: make kobj_type structures constant
2023-02-10 08:59:48 -08:00
xfs_sysfs.h
xfs: make kobj_type structures constant
2023-02-10 08:59:48 -08:00
xfs_trace.c
xfs: add debug knob to slow down writeback for fun
2022-11-28 17:24:35 -08:00
xfs_trace.h
xfs: fix finding a last resort AG in xfs_filestream_pick_ag
2024-11-08 16:28:26 +01:00
xfs_trans_ail.c
xfs: don't reverse order of items in bulk AIL insertion
2023-06-29 09:28:23 -07:00
xfs_trans_buf.c
xfs: introduce xfs_buf_daddr()
2021-08-19 10:07:14 -07:00
xfs_trans_dquot.c
xfs: remove quota warning limit from struct xfs_quota_limits
2022-05-11 17:12:09 +10:00
xfs_trans_priv.h
xfs: convert log vector chain to use list heads
2022-07-07 18:55:59 +10:00
xfs_trans.c
xfs: only run precommits once per transaction object
2024-12-19 18:11:25 +01:00
xfs_trans.h
xfs: don't use current->journal_info
2024-06-21 14:38:45 +02:00
xfs_xattr.c
xfs: require a relatively recent V5 filesystem for LARP mode
2023-09-12 10:31:08 -07:00
xfs_xattr.h
xfs: move xfs_attr_use_log_assist usage out of libxfs
2022-05-27 10:34:04 +10:00
xfs.h
xfs: verify buffer, inode, and dquot items every tx commit
2024-12-27 13:58:44 +01:00