Dan Carpenter 134f66959c
scsi: qla2xxx: Silence a static checker warning ...
Smatch and Clang both complain that LOGIN_TEMPLATE_SIZE is more than
sizeof(ha->plogi_els_payld.fl_csp).
Smatch warning:
drivers/scsi/qla2xxx/qla_iocb.c:3075 qla24xx_els_dcmd2_iocb()
warn: '&ha->plogi_els_payld.fl_csp' sometimes too small '16' size = 112
Clang warning:
include/linux/fortify-string.h:592:4: error: call to
'__read_overflow2_field' declared with 'warning' attribute: detected
read beyond size of field (2nd parameter); maybe use struct_group()?
[-Werror,-Wattribute-warning]
__read_overflow2_field(q_size_field, size);
When I was reading this code I assumed the "- 4" meant that we were
skipping the last 4 bytes but actually it turned out that we are
skipping the first four bytes.
I have re-written it remove the magic numbers, be more clear and
silence the static checker warnings.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org >
Link: https://lore.kernel.org/r/4aa0485e-766f-4b02-8d5d-c6781ea8f511@moroto.mountain
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2023-07-05 21:28:37 -04:00
2023-04-27 11:53:57 -07:00
2023-04-13 13:13:53 -07:00
2023-05-04 20:23:41 +02:00
2023-04-13 13:13:50 -07:00
2023-05-31 11:20:49 -04:00
2023-04-27 19:42:02 -07:00
2023-04-14 15:32:56 +03:00
2023-05-07 10:00:09 -07:00
2023-04-23 22:07:27 -07:00
2023-04-27 16:36:55 -07:00
2023-04-27 16:21:32 -07:00
2023-05-01 10:37:37 -07:00
2023-05-07 10:31:45 -07:00
2023-04-29 10:24:30 -07:00
2023-05-02 10:41:31 -07:00
2023-04-27 11:53:57 -07:00
2023-04-29 13:04:50 -07:00
2023-05-07 10:57:14 -07:00
2023-04-30 11:51:51 -07:00
2023-04-27 19:57:00 -07:00
2023-04-27 11:53:57 -07:00
2023-05-03 11:11:56 -07:00
2023-04-27 19:42:02 -07:00
2023-04-27 11:53:57 -07:00
2023-04-05 15:10:14 -05:00
2023-04-27 11:27:48 -07:00
2023-04-29 17:42:33 -07:00
2023-04-27 12:07:50 -07:00
2023-05-03 11:00:27 -07:00
2023-05-05 11:49:22 -07:00
2023-04-27 11:53:57 -07:00
2023-04-05 19:41:10 +02:00
2023-04-27 10:09:05 -07:00
2023-04-27 17:17:12 -07:00
2023-04-27 11:53:57 -07:00
2023-04-13 13:13:52 -07:00
2023-04-19 15:08:11 +02:00
2023-05-03 17:27:29 +02:00
2023-04-30 23:50:26 +02:00
2023-04-27 19:37:36 +02:00
2023-04-27 12:07:50 -07:00
2023-04-29 17:21:24 -07:00
2023-05-01 17:18:56 -07:00
2023-04-27 16:36:55 -07:00
2023-04-30 13:00:38 -07:00
2023-04-27 19:42:02 -07:00
2023-05-05 19:12:01 -07:00
2023-05-02 10:36:02 -07:00
2023-04-28 16:24:32 -07:00
2023-05-07 10:17:33 -07:00
2023-04-20 14:24:01 +02:00
2023-05-22 16:35:02 -04:00
2023-04-30 13:00:38 -07:00
2023-04-25 12:02:16 -07:00
2023-04-05 11:45:35 +02:00
2023-05-31 19:59:26 -04:00
2023-05-02 10:41:31 -07:00
2023-04-28 14:02:54 -07:00
2023-04-27 11:46:26 -07:00
2023-05-03 18:58:59 -07:00
2023-05-05 19:12:01 -07:00
2023-04-24 18:12:42 -07:00
2023-04-03 21:42:52 +02:00
2023-05-22 16:35:02 -04:00
2023-04-27 16:36:55 -07:00
2023-05-05 13:27:59 -07:00
2023-04-27 10:09:05 -07:00
2023-05-03 17:43:26 +02:00
2023-03-23 12:22:19 +09:00
2023-04-30 11:51:51 -07:00
2023-04-03 21:42:52 +02:00
2023-03-23 13:20:40 +01:00
2023-04-29 13:04:50 -07:00
2023-05-05 11:57:29 -07:00
2023-05-02 15:40:41 -07:00
2023-04-27 16:36:55 -07:00
2023-04-04 10:43:52 -05:00
2023-04-29 17:37:02 -07:00
2023-04-27 11:53:57 -07:00
2023-05-03 11:25:01 -07:00
2023-04-27 19:57:00 -07:00
2023-04-27 16:36:55 -07:00
2023-04-27 19:57:00 -07:00
2023-04-29 17:29:39 -07:00
2023-04-27 11:53:57 -07:00
2023-05-02 10:41:31 -07:00
2023-05-22 16:35:02 -04:00
2023-04-27 11:53:57 -07:00
2023-07-05 21:28:37 -04:00
2023-04-27 16:36:55 -07:00
2023-04-12 15:36:55 +05:30
2023-04-27 12:07:50 -07:00
2023-04-20 14:16:39 +02:00
2023-04-27 16:36:55 -07:00
2023-06-28 21:58:36 -04:00
2023-04-27 11:53:57 -07:00
2023-05-04 20:30:18 +02:00
2023-04-19 11:42:44 +02:00
2023-04-27 12:07:50 -07:00
2023-06-28 22:22:43 -04:00
2023-04-27 12:07:50 -07:00
2023-04-27 17:05:34 -07:00
2023-05-02 11:56:43 -07:00
2023-04-28 14:53:30 -07:00
2023-05-02 10:46:11 -07:00
2023-04-27 10:09:05 -07:00
2023-04-27 19:42:02 -07:00
2023-04-27 12:07:50 -07:00
2023-05-04 18:33:56 -07:00
2023-04-27 17:27:06 -07:00
2023-03-29 12:26:32 +02:00
2023-03-29 12:26:32 +02:00
134f66959c