Takatoshi Akiyama 1be2266392
serial: sh-sci: Fix unlocked access to SCSCR register ...
The SCSCR register access in sci_break_ctl() is not locked.
sci_start_tx() and sci_set_termios() changes the SCSCR register,
but does not lock sci_port.
Therefore, this patch adds lock during register access.
Also, remove the log output that leads to a double lock.
Some analysis of where locks are not taken is as follows.
It appears that the lock is not taken in:
- sci_start_tx(), sci_stop_tx() as this is installed as a callback.
And all callers of the callback take the lock.
- start_rx as callers take the lock.
- stop_rx. this is both installed as a callback and called directly.
In both cases the caller takes the lock.
Signed-off-by: Takatoshi Akiyama <takatoshi.akiyama.kj@ps.hitachi-solutions.com >
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com >
Signed-off-by: Simon Horman <horms+renesas@verge.net.au >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-11-04 12:08:53 +01:00
2017-10-20 14:24:44 +02:00
2017-10-03 17:54:24 -07:00
2017-10-02 12:21:30 -07:00
2017-08-09 22:43:50 -07:00
2017-09-18 16:06:00 +02:00
2017-10-03 08:57:07 -07:00
2017-08-08 14:44:40 +03:00
2017-10-06 12:13:50 -07:00
2017-08-17 22:51:50 +03:00
2017-09-10 20:40:00 -07:00
2017-09-24 11:34:28 -07:00
2017-10-04 09:19:13 -07:00
2017-09-25 09:36:15 +02:00
2017-09-26 01:10:08 +02:00
2017-09-19 23:10:51 +02:00
2017-09-20 17:42:42 +08:00
2017-09-14 13:43:16 -07:00
2017-08-28 10:31:08 +09:00
2017-09-07 14:03:05 -07:00
2017-08-14 13:01:25 -04:00
2017-08-21 17:59:38 +02:00
2017-08-25 09:32:27 +09:00
2017-09-14 11:59:30 +02:00
2017-08-28 16:24:22 +02:00
2017-09-19 09:20:33 +02:00
2017-08-28 17:15:16 +02:00
2017-09-07 13:51:13 -07:00
2017-10-06 11:09:47 +10:00
2017-10-05 10:28:12 -07:00
2017-09-22 10:29:54 +02:00
2017-10-01 08:46:54 -07:00
2017-09-22 10:28:00 +02:00
2017-10-07 10:07:51 -07:00
2017-10-03 14:03:31 -05:00
2017-09-05 12:19:08 -07:00
2017-09-25 10:58:22 +02:00
2017-10-04 15:28:49 -04:00
2017-09-22 17:23:41 -10:00
2017-09-27 17:01:35 +02:00
2017-09-25 21:23:44 +02:00
2017-09-20 16:01:36 -07:00
2017-09-23 21:17:43 +02:00
2017-09-01 16:42:54 +10:00
2017-09-07 13:23:37 -07:00
2017-09-05 11:08:17 -07:00
2017-10-06 12:13:50 -07:00
2017-10-04 17:11:53 -07:00
2017-09-10 20:40:00 -07:00
2017-08-29 21:51:45 -04:00
2017-09-14 11:59:30 +02:00
2017-09-29 14:19:44 +10:00
2017-10-04 10:50:36 +02:00
2017-09-27 17:33:28 +02:00
2017-08-29 13:46:35 +02:00
2017-10-03 15:39:56 -07:00
2017-08-01 13:31:44 -04:00
2017-09-18 17:29:01 -07:00
2017-10-04 11:42:53 +02:00
2017-09-18 16:12:26 +02:00
2017-09-12 13:30:06 -07:00
2017-08-24 18:46:44 +02:00
2017-09-05 11:08:17 -07:00
2017-09-25 18:34:54 -05:00
2017-08-29 15:21:53 +02:00
2017-09-22 15:11:46 +01:00
2017-09-15 20:43:33 -07:00
2017-09-12 15:58:45 +02:00
2017-09-27 00:04:43 -07:00
2017-09-14 11:59:30 +02:00
2017-09-09 14:44:39 -07:00
2017-09-08 18:26:51 -07:00
2017-08-22 11:04:51 -07:00
2017-09-11 13:04:32 -07:00
2017-10-03 17:54:24 -07:00
2017-09-07 13:51:13 -07:00
2017-09-09 14:34:38 -07:00
2017-09-21 12:44:01 +02:00
2017-09-04 10:52:30 -07:00
2017-09-13 10:56:00 -07:00
2017-09-19 08:36:19 +02:00
2017-10-07 12:34:16 -07:00
2017-09-15 20:43:33 -07:00
2017-09-05 12:45:03 -07:00
2017-08-28 13:52:22 +02:00
2017-09-25 10:58:22 +02:00
2017-09-14 18:13:32 -07:00
2017-08-04 10:30:27 +02:00
2017-09-08 11:20:04 +08:00
2017-09-05 12:45:03 -07:00
2017-11-04 12:08:53 +01:00
2017-09-28 12:41:56 +03:00
2017-09-18 11:28:23 +02:00
2017-08-30 14:03:42 -06:00
2017-09-08 18:26:49 -07:00
2017-09-14 13:33:33 -07:00
2017-08-29 08:52:51 -05:00
2017-09-07 21:11:05 -07:00
2017-09-09 14:44:39 -07:00
2017-09-15 20:43:33 -07:00
2017-09-29 12:24:28 -07:00
2017-08-24 09:57:28 +02:00
1be2266392