Files
linux/fs/btrfs
Eric Sandeen 26401cbceb btrfs: fix use of uninit "ret" in end_extent_writepage()
commit 3e2426bd0e upstream.

If this condition in end_extent_writepage() is false:

	if (tree->ops && tree->ops->writepage_end_io_hook)

we will then test an uninitialized "ret" at:

	ret = ret < 0 ? ret : -EIO;

The test for ret is for the case where ->writepage_end_io_hook
failed, and we'd choose that ret as the error; but if
there is no ->writepage_end_io_hook, nothing sets ret.

Initializing ret to 0 should be sufficient; if
writepage_end_io_hook wasn't set, (!uptodate) means
non-zero err was passed in, so we choose -EIO in that case.

Signed-of-by: Eric Sandeen <sandeen@redhat.com>

Signed-off-by: Chris Mason <clm@fb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-30 20:09:46 -07:00
..
2013-12-20 07:45:12 -08:00
2013-05-06 15:54:49 -04:00
2008-09-25 11:04:06 -04:00
2013-05-06 15:54:34 -04:00
2012-10-09 09:14:45 -04:00
2014-03-06 21:30:06 -08:00
2013-03-14 14:57:10 -04:00
2013-02-01 14:24:23 -05:00
2013-02-01 14:24:23 -05:00
2012-10-09 09:19:57 -04:00