Files
linux/include/linux
Jeff Layton c0cef30e4f iversion: make inode_cmp_iversion{+raw} return bool instead of s64
As Linus points out:

    The inode_cmp_iversion{+raw}() functions are pure and utter crap.

    Why?

    You say that they return 0/negative/positive, but they do so in a
    completely broken manner. They return that ternary value as the
    sequence number difference in a 's64', which means that if you
    actually care about that ternary value, and do the *sane* thing that
    the kernel-doc of the function implies is the right thing, you would
    do

        int cmp = inode_cmp_iversion(inode, old);
        if (cmp < 0 ...

    and as a result you get code that looks sane, but that doesn't
    actually *WORK* right.

Since none of the callers actually care about the ternary value here,
convert the inode_cmp_iversion{+raw} functions to just return a boolean
value (false for matching, true for non-matching).

This matches the existing use of these functions just fine, and makes it
simple to convert them to return a ternary value in the future if we
grow callers that need it.

With this change we can also reimplement inode_cmp_iversion in a simpler
way using inode_peek_iversion.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-01-31 08:43:35 -08:00
..
2018-01-08 11:03:35 +00:00
2016-07-08 16:23:11 +02:00
2017-11-30 16:55:35 +00:00
2017-06-08 18:52:36 -07:00
2017-12-21 02:15:41 +01:00
2017-11-15 18:21:04 -08:00
2018-01-03 14:03:48 +01:00
2017-08-24 13:23:03 -07:00
2016-10-28 08:48:16 -06:00
2017-11-27 16:19:56 -05:00
2017-07-17 13:42:48 +02:00
2018-01-25 14:10:39 -08:00
2017-08-07 17:22:14 +02:00
2017-11-13 01:41:20 +01:00
2017-11-15 18:21:06 -08:00
2017-03-21 10:15:47 +02:00
2017-05-18 10:07:40 -04:00
2017-06-21 14:37:12 -04:00
2018-01-17 11:30:16 +00:00
2017-11-15 18:21:05 -08:00
2017-12-29 21:13:04 +01:00
2017-11-15 18:21:01 -08:00
2017-11-17 16:10:04 -08:00
2017-10-12 15:41:05 +02:00
2017-11-15 18:21:01 -08:00
2017-12-01 13:09:40 -08:00
2017-10-19 10:08:56 +02:00
2017-10-07 10:45:02 -06:00
2017-02-24 17:46:57 -08:00
2017-08-28 20:51:22 +02:00
2017-11-15 18:21:04 -08:00
2017-11-27 16:19:52 -05:00
2017-11-17 16:10:00 -08:00
2017-07-25 18:05:25 +02:00
2017-10-20 09:37:32 +02:00
2017-12-14 16:00:49 -08:00
2017-11-15 18:21:03 -08:00
2017-11-15 18:21:06 -08:00
2017-11-09 10:23:28 +01:00
2017-08-06 20:55:29 -07:00
2017-11-17 16:10:04 -08:00
2017-11-17 16:10:04 -08:00
2017-11-13 01:33:48 +01:00
2017-12-16 02:05:48 +01:00
2017-11-27 16:19:55 -05:00
2017-11-07 12:22:21 +01:00
2017-11-27 16:19:55 -05:00
2017-07-06 16:24:30 -07:00
2017-08-16 16:28:47 -07:00
2017-11-15 18:21:01 -08:00
2017-11-15 18:21:06 -08:00
2017-11-15 18:21:01 -08:00
2018-01-18 11:56:49 +01:00
2017-10-11 22:36:54 -04:00
2017-07-24 17:50:37 +02:00
2017-10-04 10:29:22 +02:00
2017-11-27 16:19:54 -05:00
2017-08-15 09:02:07 -07:00
2017-08-15 09:02:08 -07:00