Files
linux/drivers/char
Jiri Slaby 004e147bd3 TTY: ldisc, fix open flag handling
commit 7f90cfc505 upstream.

When a concrete ldisc open fails in tty_ldisc_open, we forget to clear
TTY_LDISC_OPEN. This causes a false warning on the next ldisc open:
WARNING: at drivers/char/tty_ldisc.c:445 tty_ldisc_open+0x26/0x38()
Hardware name: System Product Name
Modules linked in: ...
Pid: 5251, comm: a.out Tainted: G        W  2.6.32-5-686 #1
Call Trace:
 [<c1030321>] ? warn_slowpath_common+0x5e/0x8a
 [<c1030357>] ? warn_slowpath_null+0xa/0xc
 [<c119311c>] ? tty_ldisc_open+0x26/0x38
 [<c11936c5>] ? tty_set_ldisc+0x218/0x304
...

So clear the bit when failing...

Introduced in c65c9bc3ef (tty: rewrite the ldisc locking) back in
2.6.31-rc1.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@linux.intel.com>
Reported-by: Sergey Lapin <slapin@ossfans.org>
Tested-by: Sergey Lapin <slapin@ossfans.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-09 13:26:47 -08:00
..
2009-06-11 08:51:01 -07:00
2009-09-24 07:21:03 -07:00
2009-07-12 12:22:34 -07:00
2005-04-16 15:20:36 -07:00
2008-06-20 14:05:55 -06:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-12-13 11:25:49 -08:00
2009-10-01 16:11:16 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-10-20 08:52:41 -07:00
2008-12-13 09:12:07 +00:00
2009-10-04 15:05:10 -07:00
2008-07-20 17:12:36 -07:00
2005-04-16 15:20:36 -07:00
2010-12-09 13:26:36 -08:00
2009-06-18 11:16:55 +10:00
2009-01-02 10:28:32 -08:00
2009-09-15 08:42:00 -07:00
2008-02-07 08:42:25 -08:00
2009-09-23 07:39:29 -07:00
2009-07-12 12:22:34 -07:00
2008-04-30 08:29:43 -07:00
2009-07-12 12:22:34 -07:00
2009-07-12 12:22:34 -07:00
2007-02-12 09:48:30 -08:00
2009-06-18 13:03:54 -07:00
2009-10-11 11:20:58 -07:00
2010-02-09 04:50:58 -08:00
2010-04-26 07:41:19 -07:00
2005-04-16 15:20:36 -07:00
2009-09-19 13:13:37 -07:00
2008-07-20 17:12:38 -07:00
2009-07-12 12:22:34 -07:00
2009-02-22 09:23:02 -08:00
2009-06-11 08:51:01 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-07-20 17:12:38 -07:00
2009-07-12 12:22:34 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2009-09-01 01:13:31 -07:00
2009-09-01 01:13:31 -07:00
2009-09-01 01:13:31 -07:00
2009-07-03 15:45:29 +01:00
2008-04-30 23:15:34 +02:00
2009-06-11 08:51:02 -07:00
2009-09-19 13:13:35 -07:00
2010-12-09 13:26:47 -08:00
2009-09-19 13:13:35 -07:00