Files
linux/drivers/usb/host
Mathias Nyman c0f94181a7 xhci: fix off by one error in TRB DMA address boundary check
commit 7895086afd upstream.

We need to check that a TRB is part of the current segment
before calculating its DMA address.

Previously a ring segment didn't use a full memory page, and every
new ring segment got a new memory page, so the off by one
error in checking the upper bound was never seen.

Now that we use a full memory page, 256 TRBs (4096 bytes), the off by one
didn't catch the case when a TRB was the first element of the next segment.

This is triggered if the virtual memory pages for a ring segment are
next to each in increasing order where the ring buffer wraps around and
causes errors like:

[  106.398223] xhci_hcd 0000:00:14.0: ERROR Transfer event TRB DMA ptr not part of current TD ep_index 0 comp_code 1
[  106.398230] xhci_hcd 0000:00:14.0: Looking for event-dma fffd3000 trb-start fffd4fd0 trb-end fffd5000 seg-start fffd4000 seg-end fffd4ff0

The trb-end address is one outside the end-seg address.

Tested-by: Arkadiusz Miśkiewicz <arekm@maven.pl>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-08-16 20:51:36 -07:00
..
2012-11-21 13:27:17 -08:00
2012-11-21 13:27:17 -08:00
2012-11-21 13:27:17 -08:00
2012-02-13 14:32:34 -08:00
2011-03-31 11:26:23 -03:00
2012-05-01 21:33:37 -07:00
2012-11-21 13:27:16 -08:00
2012-11-21 13:27:17 -08:00
2012-11-21 13:27:16 -08:00
2012-11-21 13:27:16 -08:00
2012-11-21 13:27:16 -08:00
2012-11-21 13:27:16 -08:00
2012-11-21 13:27:17 -08:00
2013-01-24 13:59:26 -08:00
2012-11-21 13:27:16 -08:00
2013-01-25 12:41:02 -08:00
2013-01-24 13:42:09 -08:00